Clean up redundant Mms/Sms queries #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasSession
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have
MmsSmsDatabasewhere theMessageRecordgets filled up by a standard unified query into the database.However I just found out that each database class (
SmsDatabaseandMmsDatabase) also comes with their duplicated version of query to mimick the unified query, which is very scary to me because we have added a few more things to the unified query and didn't update the duplicated ones. So some of the queries have been missing some data for a while.This PR removes the separate query that happens on the inidividual database class, now only the
MmsSmsDatabasecan construct theMessageRecordfrom the query result.This is paving way to add the
pro_featurescolumn into the mix.