Improve community reaction handling #1733
Merged
+87
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community reactions work very differently from normal reactions, including how they are counted. When you react to a message, we need to call the server API to do that and it takes time. To show the reaction result immediately, we used to write to a temporary location in the memory - that bit of code was removed a while ago, it then falls purely on counting that in the db - which in some cases had it wrong because how the data is stored is very precarious. I've updated the code to improve this area and now you should see the reaction in community messages more reliably.
Also fixing SES-4535 - where there's another place that counts reaction so it also needs updating.