Disconnect from deregged SNs after a delay #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
force-pushed
the
disconnect-deregged
branch
3 times, most recently
from
c9fdfe9 to
dac05fc
Compare
When a node leaves the network, currently we just keep an established connection to that node alive as long as it stays up. This fixes that by adding a check for deregged nodes and, if found, disconnects them after half an hour. The delay here is to attempt to not kill existing client paths that may still be using a path through us to the deregged node, allowing some time for the client to replace the path with new paths that don't use it.
Actually close the connections. Quiet closing doesn't seem to have a purpose, and moreover seems like a hack to avoid having to deal with proper callbacks, so this changes all the "close quietly" to just "close". This ended up triggering warnings in the close callback about closing an untracked connection, so this also addresses those by using a specific close error code for those connections so that we can detect them and debug instead of warn for them.
jagerman
force-pushed
the
disconnect-deregged
branch
from
4fd1149 to
18470c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node leaves the network, currently we just keep an established connection to that node alive as long as it stays up.
This fixes that by adding a check for deregged nodes and, if found, disconnects them after half an hour.
The delay here is to attempt to not kill existing client paths that may still be using a path through us to the deregged node, allowing some time for the client to replace the path with new paths that don't use it.