Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rscript_path as optional parameter #45

Merged
merged 4 commits into from Nov 8, 2019
Merged

Conversation

@polvanrijn
Copy link

@polvanrijn polvanrijn commented Oct 21, 2019

No description provided.

@polvanrijn
Copy link
Author

@polvanrijn polvanrijn commented Oct 22, 2019

This feature is really nice if multiple R interpreters are installed or first need to be loaded using module. I didn't describe @param rscript_path

Copy link
Contributor

@qdread qdread left a comment

This seems like it would not cause any conflicts and should be fine to merge

Include description of rscript_path argument for both functions
@qdread
Copy link
Contributor

@qdread qdread commented Nov 7, 2019

This now fails because of an issue with if-test using the logical operator || failing checks in R 3.6.

See this issue.

qdread added 2 commits Nov 7, 2019
previously had caused check to fail with R 3.6
Resolved by adding any() to second condition after ||
Remove empty section of NEWS.Rd
Explicitly import read.table from utils
@qdread qdread merged commit 3e43e8d into SESYNC-ci:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.