fix(cli): add env validation to Blockscout, IPFS, and Minio codegen

- Replace non-null assertions with runtime environment variable validation
- Add proper error messages for missing required configuration
- Improve generated code safety for Blockscout UI endpoint
- Enhance IPFS API endpoint validation
- Strengthen Minio client configuration with access key validation

Author: roderik

sdk/cli/src/commands/codegen/codegen-blockscout.ts

@@ -1,13 +1,13 @@
 import { rm, writeFile } from "node:fs/promises";
 import { basename, resolve } from "node:path";
-import { writeTemplate } from "@/commands/codegen/utils/write-template";
-import { getApplicationOrPersonalAccessToken } from "@/utils/get-app-or-personal-token";
 import { generateSchema } from "@gql.tada/cli-utils";
 import { projectRoot } from "@settlemint/sdk-utils/filesystem";
 import { appendHeaders, graphqlFetchWithRetry } from "@settlemint/sdk-utils/http";
 import { installDependencies, isPackageInstalled } from "@settlemint/sdk-utils/package-manager";
 import { note } from "@settlemint/sdk-utils/terminal";
 import { type DotEnv, LOCAL_INSTANCE, STANDALONE_INSTANCE } from "@settlemint/sdk-utils/validation";
+import { writeTemplate } from "@/commands/codegen/utils/write-template";
+import { getApplicationOrPersonalAccessToken } from "@/utils/get-app-or-personal-token";
 
 const PACKAGE_NAME = "@settlemint/sdk-blockscout";
 
@@ -167,6 +167,18 @@ import { createLogger, requestLogger, type LogLevel } from '@settlemint/sdk-util
 
 const logger = createLogger({ level: process.env.SETTLEMINT_LOG_LEVEL as LogLevel });
 
+// Validate required environment variables
+const blockscoutEndpoint = process.env.SETTLEMINT_BLOCKSCOUT_ENDPOINT;
+const blockscoutUiEndpointVar = process.env.SETTLEMINT_BLOCKSCOUT_UI_ENDPOINT;
+
+if (!blockscoutEndpoint) {
+  throw new Error('SETTLEMINT_BLOCKSCOUT_ENDPOINT environment variable is required');
+}
+
+if (!blockscoutUiEndpointVar) {
+  throw new Error('SETTLEMINT_BLOCKSCOUT_UI_ENDPOINT environment variable is required');
+}
+
 export const { client: blockscoutClient, graphql: blockscoutGraphql } = createBlockscoutClient<{
   introspection: introspection;
   disableMasking: true;
@@ -189,13 +201,13 @@ export const { client: blockscoutClient, graphql: blockscoutGraphql } = createBl
     Wei: string;
   };
 }>({
-  instance: process.env.SETTLEMINT_BLOCKSCOUT_ENDPOINT!,
+  instance: blockscoutEndpoint,
   accessToken: process.env.SETTLEMINT_ACCESS_TOKEN,
 }, {
   fetch: requestLogger(logger, "blockscout", fetch) as typeof fetch,
 });
 
-export const blockscoutUiEndpoint = process.env.SETTLEMINT_BLOCKSCOUT_UI_ENDPOINT!;`;
+export const blockscoutUiEndpoint = blockscoutUiEndpointVar;`;
 
   await writeTemplate(template, "/lib/settlemint", "blockscout.ts");
 

sdk/cli/src/commands/codegen/codegen-ipfs.ts

@@ -1,7 +1,7 @@
-import { writeTemplate } from "@/commands/codegen/utils/write-template";
 import { projectRoot } from "@settlemint/sdk-utils/filesystem";
 import { installDependencies, isPackageInstalled } from "@settlemint/sdk-utils/package-manager";
 import type { DotEnv } from "@settlemint/sdk-utils/validation";
+import { writeTemplate } from "@/commands/codegen/utils/write-template";
 
 const PACKAGE_NAME = "@settlemint/sdk-ipfs";
 
@@ -17,8 +17,15 @@ export async function codegenIpfs(env: DotEnv) {
 
   const clientTemplate = `import { createServerIpfsClient } from "${PACKAGE_NAME}";
 
+// Validate required environment variables
+const ipfsApiEndpoint = process.env.SETTLEMINT_IPFS_API_ENDPOINT;
+
+if (!ipfsApiEndpoint) {
+  throw new Error('SETTLEMINT_IPFS_API_ENDPOINT environment variable is required');
+}
+
 export const { client } = createServerIpfsClient({
-  instance: process.env.SETTLEMINT_IPFS_API_ENDPOINT!,
+  instance: ipfsApiEndpoint,
   accessToken: process.env.SETTLEMINT_ACCESS_TOKEN,
 });`;
 

sdk/cli/src/commands/codegen/codegen-minio.ts

@@ -1,7 +1,7 @@
-import { writeTemplate } from "@/commands/codegen/utils/write-template";
 import { projectRoot } from "@settlemint/sdk-utils/filesystem";
 import { installDependencies, isPackageInstalled } from "@settlemint/sdk-utils/package-manager";
 import type { DotEnv } from "@settlemint/sdk-utils/validation";
+import { writeTemplate } from "@/commands/codegen/utils/write-template";
 
 const PACKAGE_NAME = "@settlemint/sdk-minio";
 
@@ -17,10 +17,27 @@ export async function codegenMinio(env: DotEnv) {
 
   const clientTemplate = `import { createServerMinioClient } from "${PACKAGE_NAME}";
 
+// Validate required environment variables
+const minioEndpoint = process.env.SETTLEMINT_MINIO_ENDPOINT;
+const minioAccessKey = process.env.SETTLEMINT_MINIO_ACCESS_KEY;
+const minioSecretKey = process.env.SETTLEMINT_MINIO_SECRET_KEY;
+
+if (!minioEndpoint) {
+  throw new Error('SETTLEMINT_MINIO_ENDPOINT environment variable is required');
+}
+
+if (!minioAccessKey) {
+  throw new Error('SETTLEMINT_MINIO_ACCESS_KEY environment variable is required');
+}
+
+if (!minioSecretKey) {
+  throw new Error('SETTLEMINT_MINIO_SECRET_KEY environment variable is required');
+}
+
 export const { client } = createServerMinioClient({
-  instance: process.env.SETTLEMINT_MINIO_ENDPOINT!,
-  accessKey: process.env.SETTLEMINT_MINIO_ACCESS_KEY!,
-  secretKey: process.env.SETTLEMINT_MINIO_SECRET_KEY!
+  instance: minioEndpoint,
+  accessKey: minioAccessKey,
+  secretKey: minioSecretKey
 });`;
 
   await writeTemplate(clientTemplate, "/lib/settlemint", "minio.ts");