fix: e2e tests #1034
Merged
fix: e2e tests #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR fixes end-to-end tests by correcting schema documentation to reference the IPFS client, adding a post-restart health check in the restart-resources test to assert an unauthorized response without a token, and installing node-gyp globally in the CI workflow to support native dependencies. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Caution Review failedThe pull request is closed. WalkthroughThe changes update GitHub Actions to install Changes
Sequence Diagram(s)sequenceDiagram
participant Test as E2E Test
participant Env as Env Loader
participant Portal as Portal REST Endpoint
Test->>Env: loadEnv()
Test->>Portal: fetchWithRetry(REST endpoint)
Portal-->>Test: HTTP 401 Unauthorized
Test->>Test: Assert response status is 401
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📦 Packages
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @janb87 - I've reviewed your changes - here's some feedback:
- The e2e restart test only asserts a 401 on an unauthenticated request—consider also adding a successful request with a valid token to verify the service is fully operational after restart.
- Installing node-gyp globally via
bun install -gcan lead to version drift; consider moving it into your devDependencies or using a reproducible install step to ensure native modules build consistently in CI.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+67
to
+68
| - name: Install Node Gyp | ||
| run: bun install -g node-gyp |
There was a problem hiding this comment.
suggestion (bug_risk): Using bun install -g for global installation may not work
Bun does not handle the -g flag like npm. Use npm install -g node-gyp or add node-gyp as a devDependency and run bun install instead.
Suggested change
| - name: Install Node Gyp | |
| run: bun install -g node-gyp | |
| - name: Install Node Gyp | |
| run: npm install -g node-gyp |
snigdha920
added a commit
that referenced
this pull request
May 23, 2025
…orkflows-on-events * main: chore(deps): update dependency knip to v5.57.2 (#1037) chore(deps): update dependency @modelcontextprotocol/sdk to v1.12.0 (#1038) chore(deps): update dependency @types/bun to v1.2.14 (#1036) fix: e2e tests (#1034) chore(deps): update dependency knip to v5.57.1 (#1032) chore(deps): update node.js to v22.16.0 (#1033) chore(deps): update dependency @modelcontextprotocol/sdk to v1.11.5 (#1030) chore(deps): update dependency bun to v1.2.14 (#1031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update IPFS client schema comments, strengthen restart-resources e2e test with an unauthorized status check, and add Node Gyp installation to the CI e2e workflow
CI:
Tests:
Chores:
Summary by CodeRabbit
Documentation
Chores
Tests