Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Credit Cards #40
I saw you removed the association validation on valid_credit_card method, so you can pass a "valid credit card number", but without correct association. I understand you are using into a controlled environment (test), but if anyone copy this code from your test suite, can get invalid result ;)
That was precisely my line of reasoning. The trade-off appeared to be between more complete test coverage and more informative failures, and I chose more informative failures. I tried to work around the reduced coverage by having more, and a good mix of
That said, if anyone feels strongly about it, I'm certainly open to modifying the tests!