New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run checkstyle checks on sources of sevntu.checkstyle #310

Closed
rdiachenko opened this Issue Feb 6, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@rdiachenko
Member

rdiachenko commented Feb 6, 2015

When a new check is created a developer should run his check on the existing checks sources, analyze and fix violations.

The purpose of this issue it to automate this process by the following steps:

  • Update maven build configuration for sevntu-checks module to run all checkstyle-checks.xml from Checkstyle repositoy on sources, as that is requirement for all checks that are going to appear in main repo.
  • The build should failed until all the violations will be fixed

Think about how to enforce the developer to add his new check to the list of already running checks in order so the probable violations from this new check will be fixed by developer before pull request.

@romani romani changed the title from Run sevntu-checks on their own sources to Run checkstyle checks on sources of sevntu.checkstyle Feb 7, 2015

@damianszczepanik

This comment has been minimized.

Show comment
Hide comment
@damianszczepanik

damianszczepanik Mar 1, 2015

Contributor

I've done it already for code coverage in https://github.com/damianszczepanik/sevntu.checkstyle/commit/a2f6734b0e3140021e56912e29fba8a264a98539 so I expect validating against checkstyle rules should work similar.

Have you prepared list of rules that shall be applied? I expect some of them are similar to Sonar but Sonar uses different approach and may check more than checkstyle (PMD, FindBugs).

We'd better start to clean #169 and then this one would be easier because we will not have exception for each class :)

Contributor

damianszczepanik commented Mar 1, 2015

I've done it already for code coverage in https://github.com/damianszczepanik/sevntu.checkstyle/commit/a2f6734b0e3140021e56912e29fba8a264a98539 so I expect validating against checkstyle rules should work similar.

Have you prepared list of rules that shall be applied? I expect some of them are similar to Sonar but Sonar uses different approach and may check more than checkstyle (PMD, FindBugs).

We'd better start to clean #169 and then this one would be easier because we will not have exception for each class :)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 2, 2015

Member

general idea - https://github.com/checkstyle/checkstyle/wiki/Checkstyle-GSoC-2015-Project-Ideas#project-name-practice-what-you-preach , we failed to pass to GSoC 2015 so that idea will not be locked to one contributor, and we could start doing it.

right now we use - https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_checks.xml config, but eventually all Checks should be added to it. We can do the same for sevntu.checkstyle.

Member

romani commented Mar 2, 2015

general idea - https://github.com/checkstyle/checkstyle/wiki/Checkstyle-GSoC-2015-Project-Ideas#project-name-practice-what-you-preach , we failed to pass to GSoC 2015 so that idea will not be locked to one contributor, and we could start doing it.

right now we use - https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_checks.xml config, but eventually all Checks should be added to it. We can do the same for sevntu.checkstyle.

romani added a commit that referenced this issue Oct 28, 2015

romani added a commit that referenced this issue Oct 29, 2015

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Nov 19, 2016

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Nov 19, 2016

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Nov 19, 2016

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Nov 19, 2016

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Nov 21, 2016

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Nov 21, 2016

@romani

This comment has been minimized.

Show comment
Hide comment

@romani romani closed this Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment