Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo EnumValueCheck: to make it simple as all other Naming Checks #448

Closed
romani opened this issue Apr 4, 2016 · 5 comments
Closed

redo EnumValueCheck: to make it simple as all other Naming Checks #448

romani opened this issue Apr 4, 2016 · 5 comments
Labels
Milestone

Comments

@romani
Copy link
Member

@romani romani commented Apr 4, 2016

reason of bad original design: #370 (comment)

reason to keep it simple: #370 (comment)

@romani romani added the easy label Apr 4, 2016
@romani
Copy link
Member Author

@romani romani commented Apr 4, 2016

@pbaranchikov , can you help us to implement this issue ?

@rnveach
Copy link
Contributor

@rnveach rnveach commented Dec 7, 2016

We should achieve 100% code coverage with this rewrite.

@rnveach
Copy link
Contributor

@rnveach rnveach commented Feb 21, 2017

@romani AbstractNameCheck only takes 1 regular expression.
EnumValueNameCheck uses 2 expressions for what looks like if the enum is defined inside a class or is defined in a file all by itself.

Do you expect 2 checks out of this re-implementation?

@romani
Copy link
Member Author

@romani romani commented May 12, 2017

I thought we decided to not differentiate enums. So one regexp should stay

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue May 15, 2017
rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue May 15, 2017
@rnveach rnveach added the approved label May 15, 2017
romani added a commit that referenced this issue May 25, 2017
@romani romani added this to the 1.24.0 milestone May 25, 2017
@romani
Copy link
Member Author

@romani romani commented May 25, 2017

Fix is merged

@romani romani closed this May 25, 2017
romani added a commit that referenced this issue May 28, 2017
kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018
kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants