Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
reason of bad original design: #370 (comment)
reason to keep it simple: #370 (comment)
The text was updated successfully, but these errors were encountered:
@pbaranchikov , can you help us to implement this issue ?
We should achieve 100% code coverage with this rewrite.
@romani AbstractNameCheck only takes 1 regular expression.
EnumValueNameCheck uses 2 expressions for what looks like if the enum is defined inside a class or is defined in a file all by itself.
Do you expect 2 checks out of this re-implementation?
I thought we decided to not differentiate enums. So one regexp should stay
Issue sevntu-checkstyle#448: rewrote EnumValueNameCheck to follow nam…
…ing check pattern
Issue #448: rewrote EnumValueNameCheck to follow naming check pattern
Fix is merged
config: missed update of Issue #448
config: missed update of Issue sevntu-checkstyle#448
Successfully merging a pull request may close this issue.