New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo EnumValueCheck: to make it simple as all other Naming Checks #448

Closed
romani opened this Issue Apr 4, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Apr 4, 2016

reason of bad original design: #370 (comment)

reason to keep it simple: #370 (comment)

@romani romani added the easy label Apr 4, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 4, 2016

Member

@pbaranchikov , can you help us to implement this issue ?

Member

romani commented Apr 4, 2016

@pbaranchikov , can you help us to implement this issue ?

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 7, 2016

Contributor

We should achieve 100% code coverage with this rewrite.

Contributor

rnveach commented Dec 7, 2016

We should achieve 100% code coverage with this rewrite.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Feb 21, 2017

Contributor

@romani AbstractNameCheck only takes 1 regular expression.
EnumValueNameCheck uses 2 expressions for what looks like if the enum is defined inside a class or is defined in a file all by itself.

Do you expect 2 checks out of this re-implementation?

Contributor

rnveach commented Feb 21, 2017

@romani AbstractNameCheck only takes 1 regular expression.
EnumValueNameCheck uses 2 expressions for what looks like if the enum is defined inside a class or is defined in a file all by itself.

Do you expect 2 checks out of this re-implementation?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani May 12, 2017

Member

I thought we decided to not differentiate enums. So one regexp should stay

Member

romani commented May 12, 2017

I thought we decided to not differentiate enums. So one regexp should stay

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani May 25, 2017

Member

Fix is merged

Member

romani commented May 25, 2017

Fix is merged

@romani romani closed this May 25, 2017

romani added a commit that referenced this issue May 28, 2017

kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018

kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment