ForbidCertainImports: update for message #469

Closed
romani opened this Issue Sep 8, 2016 · 2 comments

Projects

None yet

2 participants

@romani
Member
romani commented Sep 8, 2016

from checkstyle/checkstyle#3412.

This message puzzles me. The import (or pattern) is not forbidden in com.puppycrawl.tools.checkstyle.checks.javadoc.InvalidJavadocTag, its usage is forbidden in main/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtils.java. It is vise versa.

I propose:
Import 'com.puppycrawl.tools.checkstyle.checks.javadoc.InvalidJavadocTag' should not match '.+.checks..+' pattern, it is forbidden. 34

@romani
Member
romani commented Sep 8, 2016

It do make sense.

@romani romani referenced this issue in checkstyle/checkstyle Sep 8, 2016
Merged

Pull #3412: Fix ForbidCertainImports config #3412

@MEZk
Contributor
MEZk commented Sep 8, 2016

@romani
I'll fix it ASAP.

@MEZk MEZk added a commit to MEZk/sevntu.checkstyle that referenced this issue Sep 8, 2016
@MEZk MEZk Issue #469: Fix violation message of ForbidCertainImportsCheck 118629d
@romani romani closed this Sep 16, 2016
@romani romani added this to the 1.22.1 milestone Oct 15, 2016
@kariem kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Dec 4, 2016
@MEZk @kariem MEZk + kariem Issue #469: Fix violation message of ForbidCertainImportsCheck (#470) dc32510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment