Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForbidCertainImports: update for message #469

Closed
romani opened this issue Sep 8, 2016 · 2 comments
Closed

ForbidCertainImports: update for message #469

romani opened this issue Sep 8, 2016 · 2 comments
Milestone

Comments

@romani
Copy link
Member

@romani romani commented Sep 8, 2016

from checkstyle/checkstyle#3412.

This message puzzles me. The import (or pattern) is not forbidden in com.puppycrawl.tools.checkstyle.checks.javadoc.InvalidJavadocTag, its usage is forbidden in main/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtils.java. It is vise versa.

I propose:
Import 'com.puppycrawl.tools.checkstyle.checks.javadoc.InvalidJavadocTag' should not match '.+.checks..+' pattern, it is forbidden. 34

@romani
Copy link
Member Author

@romani romani commented Sep 8, 2016

It do make sense.

@MEZk
Copy link
Contributor

@MEZk MEZk commented Sep 8, 2016

@romani
I'll fix it ASAP.

MEZk added a commit to MEZk/sevntu.checkstyle that referenced this issue Sep 8, 2016
romani added a commit that referenced this issue Sep 8, 2016
@romani romani closed this Sep 16, 2016
@romani romani added this to the 1.22.1 milestone Oct 15, 2016
kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants