OverridableMethodInConstructorCheck: problem with similar method names #51

Closed
romani opened this Issue Sep 20, 2012 · 2 comments

Projects

None yet

2 participants

@romani
Member
romani commented Sep 20, 2012

Bug in public methods in c-tor.
https://github.com/romani/sevntu.checkstyle/blob/master/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck.java

public ULCWorkbenchPartSite(Object input) {
    super(window, part, descriptor);
    globalActions = new ActionsHelper(part);

    init(); // warning here is corrects
    initPart(part, input); // warning here is not correct 
}
   public init() {
   ///....
   }
   private initPart() {
   ///....
   }

one case is valid another is not:
init();
initPart(part, input); // no warning should be here

Look like you have problem with name recognition as you treat them as the same methods.

@romani
Member
romani commented Oct 5, 2012

Issue is assigned to Ilja Dubinin (https://github.com/sabaka).

@sabaka sabaka was assigned Oct 7, 2012
@sabaka sabaka pushed a commit to sabaka/sevntu.checkstyle that referenced this issue Feb 22, 2013
sabaka Issue #51 fixed 8b0f848
@sabaka sabaka pushed a commit to sabaka/sevntu.checkstyle that referenced this issue Mar 6, 2013
sabaka Issue #51 fixed d9dae6b
@sabaka sabaka pushed a commit to sabaka/sevntu.checkstyle that referenced this issue Mar 9, 2013
sabaka Issue #51 fixed 3c9ab02
@romani
Member
romani commented Mar 11, 2013

fixed, pull request was applied.

@romani romani closed this Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment