AvoidHidingCauseExceptionCheck: NPE on wrapping exception and saving in field

[rnveach]

Identified in Issue #571

$ cat TestClass.java
public class Test {
    private Exception field;

    public void executeLocal() {
        try {
        }
        catch (final Exception e) {
            this.field = Test.method(new Exception(e));
        }
    }

    private static Exception method(Exception exception) {
        return exception;
    }
}


$ cat TestConfig.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">
    <property name="charset" value="UTF-8"/>

    <module name="TreeWalker">
<module name="com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck">
</module>
    </module>
</module>

$ java -jar checkstyle-7.3-sevntu-1.23.0-all.jar -c TestConfig.xml TestClass.java
Starting audit...
com.puppycrawl.tools.checkstyle.api.CheckstyleException: Exception was thrown while processing TestClass.java
    at com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:287)
    at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:205)
    at com.puppycrawl.tools.checkstyle.Main.runCheckstyle(Main.java:425)
    at com.puppycrawl.tools.checkstyle.Main.runCli(Main.java:359)
    at com.puppycrawl.tools.checkstyle.Main.main(Main.java:174)
Caused by: java.lang.NullPointerException
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:214)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.makeExceptionsList(AvoidHidingCauseExceptionCheck.java:220)
    at com.github.sevntu.checkstyle.checks.coding.AvoidHidingCauseExceptionCheck.visitToken(AvoidHidingCauseExceptionCheck.java:92)
    at com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:361)
    at com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:498)
    at com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:303)
    at com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:178)
    at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:78)
    at com.puppycrawl.tools.checkstyle.Checker.processFile(Checker.java:307)
    at com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:278)
    ... 4 more
Checkstyle ends with 1 errors.

[romani]

Fix is merged

[romani]

Fix is merged