Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-exceptions testing lauches to CI #644

Closed
romani opened this issue Jan 22, 2018 · 2 comments
Closed

Add no-exceptions testing lauches to CI #644

romani opened this issue Jan 22, 2018 · 2 comments

Comments

@romani
Copy link
Member

@romani romani commented Jan 22, 2018

when new Check is proposed in PR, after code-review almost forgot to request regression testing.
At least default execution of check should be done automatically on most our testing projects, as we do this at:
https://github.com/checkstyle/checkstyle/blob/master/wercker.yml

the same CIs could be used.

@rnveach
Copy link
Contributor

@rnveach rnveach commented Jun 9, 2018

groovy ./launch.groovy --listOfProjects projects-for-wercker.properties
--config checks-nonjavadoc-error.xml --checkstyleVersion ${CS_POM_VERSION}

Groovy scripts don't support sevntuVersion.

https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/pom.xml#L16
Default maven configuration uses release version, not snapshot version.
https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/pom.xml#L15
Default maven configuration uses snapshot version for checkstyle.

We need to be able to override both values.

@romani
Copy link
Member Author

@romani romani commented Jun 9, 2018

Fix is merged

@romani romani closed this Jun 9, 2018
kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants