New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sevntu-checks.xml refers to old dtd #648

Closed
raghavgautam opened this Issue Feb 28, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@raghavgautam
Copy link
Contributor

raghavgautam commented Feb 28, 2018

I found that sevntu-checks.xml still refers to an old(1.2) version of dtd. The current version is 1.3.

raghavgautam added a commit to raghavgautam/sevntu.checkstyle that referenced this issue Feb 28, 2018

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Feb 28, 2018

The only difference between the 2 is allowing to override Check messages with custom ones.
Sevntu hasn't had need of this so there hasn't been any reason to upgrade.
Staying on old version doesn't hurt anything, neither does going to new version.

@raghavgautam

This comment has been minimized.

Copy link
Contributor

raghavgautam commented Feb 28, 2018

@rnveach Ok.

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Feb 28, 2018

@raghavgautam If you wish to upgrade the version, you can go right ahead.

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Mar 6, 2018

Fix was merged

@rnveach rnveach closed this Mar 6, 2018

kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment