New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all modules are listed in contribution checks-sevntu-error.xml #691

Closed
rnveach opened this Issue Jun 9, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@rnveach
Copy link
Contributor

rnveach commented Jun 9, 2018

https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/checks-sevntu-error.xml
File hasn't been updated in a year. No exception testing at #644 will verify it is defined correctly, but nothing is ensuring it is populated with all modules.

Ex: MoveVariableInsideIfCheck is missing.

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Jun 9, 2018

Checkstyle project looks at sevntu module list too at https://github.com/checkstyle/checkstyle/blob/master/.ci/travis/travis.sh#L148-L158 .
We should be able to use similar code to compare the 2 files.

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Jun 9, 2018

@romani New module in Checkstyle project is rare, but do we have a similar check against checks-nonjavadoc-error.xml and checks-only-javadoc-error.xml?

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Jun 9, 2018

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Jun 9, 2018

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Jun 9, 2018

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Jun 9, 2018

https://travis-ci.org/sevntu-checkstyle/sevntu.checkstyle/jobs/390207131#L532
New CI is reporting the following modules are missing:

+CheckstyleTestMakeup
+ForbidCertainMethod
+MoveVariableInsideIf
+RequireFailForTryCatchInJunit

@romani romani added the approved label Jun 9, 2018

@romani

This comment has been minimized.

Copy link
Member

romani commented Jun 9, 2018

no objection to make to more automated

but do we have a similar check against checks-nonjavadoc-error.xml and checks-only-javadoc-error.xml?

we should add.
It is high likelihood that we will forget to do this.
and we have missed one already - AnnotationOnSameLine , that was added at 8.2 version.

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Jun 9, 2018

I will create issue in checkstyle.

@rnveach

This comment has been minimized.

Copy link
Contributor

rnveach commented Jun 9, 2018

Fix was merged.

@rnveach rnveach closed this Jun 9, 2018

kariem added a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment