Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length issue with sevntu modifying config on regression #718

Closed
rnveach opened this issue Sep 13, 2018 · 1 comment

Comments

@rnveach
Copy link
Contributor

commented Sep 13, 2018

Identified at #709 (comment)

https://travis-ci.org/sevntu-checkstyle/sevntu.checkstyle/jobs/411174590#L1048

Travis failure is reproduced on my local on your branch (not in master):
<module name="com.github.sevntu.checkstyle.checks.coding.EnumTrailingCommaAndSemicolonCheck"></module>

This is because this is the full regression test of new modules in Sevntu run on Checkstyle.
Specifically this happens in https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/src/test/java/com/github/sevntu/checkstyle/internal/CheckstyleRegressionTest.java#L104 . We pull in checkstyle's repo and modify checkstyle_sevntu_checks.xml to include all new modules in sevntu PR that are not in checkstyle. This is how we know if a new check causes any violations on checkstyle once integrated.

See https://travis-ci.org/sevntu-checkstyle/sevntu.checkstyle/jobs/411174590#L867

-- Adding Check: com.github.sevntu.checkstyle.checks.coding.EnumTrailingCommaAndSemicolonCheck
-- Adding Suppression: EnumTrailingCommaAndSemicolonCheck


Because of the new formatting restrictions placed on the XML files, CheckstyleRegressionTest will have to be modified to split the module name up since we use the full package name.

rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue Sep 14, 2018

romani added a commit that referenced this issue Sep 14, 2018

@romani romani added this to the 1.33.0 milestone Sep 14, 2018

@romani

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

Fix is merged

@romani romani closed this Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.