New Check: CheckFinalizeImplementation #72

Closed
romani opened this Issue Nov 3, 2012 · 0 comments

Projects

None yet

2 participants

@romani
Member
romani commented Nov 3, 2012
  • Correct finalize() declaration. It is not a very simple and straight forward check, need investigation.

rules are here:
http://www.ibm.com/developerworks/ru/library/j-jtp06294/#2.3

we could check all except for calling finalize from user code (3rd in list of validations).

This Check detects 3 most common cases of incorrect finalize() method implementation:

//negates effect of superclass finalize
protected void finalize() { }
protected void finalize() { doSomething(); }
//useless (or worse) finalize
protected void finalize() { super.finalize(); }
//public finalize
public void finalize() { try { doSomething(); } finally { super.finalize() } }
@maxvetrenko maxvetrenko was assigned Jan 23, 2014
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 11, 2014
@maxvetrenko maxvetrenko Fixed #72. CheckFinalizeImplementation was introduced 5dd792f
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 12, 2014
@maxvetrenko maxvetrenko Fixed #72. CheckFinalizeImplementation was introduced. 4287919
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 15, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 990aeeb
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 16, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. b47dce0
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 16, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 44babac
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 17, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 7c9959c
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 19, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. b71635c
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 20, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 7436f73
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 25, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 91548f5
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 25, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 72f7c5b
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 25, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 6e25f05
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Feb 26, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 7a9e71b
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 5, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 581511c
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 5, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. d2a75b2
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 6, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 09bb231
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 7, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. bdabab9
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 7, 2014
@maxvetrenko @maxvetrenko maxvetrenko + maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 028832d
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 12, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. a88b1d3
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 12, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. b3e024d
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 15, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. c42b966
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 15, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 78c3a60
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 15, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 1ac42c7
@maxvetrenko maxvetrenko added a commit to maxvetrenko/sevntu.checkstyle that referenced this issue Mar 15, 2014
@maxvetrenko maxvetrenko Fixed #72. FinalizeImplementationCheck was introduced. 472a8dd
@daniilyar daniilyar closed this in e881a2e Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment