Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sevntu-checks should not bundle checkstyle library #758

Closed
rnveach opened this issue Jul 3, 2019 · 9 comments

Comments

@rnveach
Copy link
Contributor

commented Jul 3, 2019

Discussed at #746 (comment) ,

We saw that bundling checkstyle into sevntu-sonar plugin caused issues as sevntu-sonar has to be installed side by side with checkstyle-sonar. The 2 sonar plugins could have different versions of checkstyle and this caused conflicts.

But why does sevntu-checks bundle checkstyle? It seems odd that sevntu-sonar plugin should not bundle it but normal sevntu-checks should.
In our own checkstyle documentation, we mention that 3rd party checks should be appended with main checkstyle jar, so I wouldn't expect others to also embed the checkstyle JAR.
See https://checkstyle.sourceforge.io/cmdline.html#Usage_by_Classpath_update

Run checkstyle with custom module(s) (Root module, Checks, etc) in configuration file:
java -classpath MyCustom.jar;checkstyle-8.22-all.jar

We should look into if we can remove checkstyle from sevntu-checks, what this means, and if there are any side effects.

@romani romani added the approved label Jul 3, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@rdiachenko , please help to fix this

@rdiachenko

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Hmm.. that was easier than I thought.. Looks like sevntu-checks doesn't bundle checkstyle library.

~/work/workspace/sevntu.checkstyle/sevntu-checks [master|✔] $ ls target/
apidocs                        generated-sources       sevntu-checks-1.34.1.jar
checkstyle-cachefile           generated-test-sources  sevntu-checks-1.34.1-javadoc.jar
checkstyle-checker.properties  javadoc-bundle-options  sevntu-checks-1.34.1-sources.jar
checkstyle-checker.xml         maven-archiver          site
checkstyle-result.xml          maven-status            surefire-reports
classes                        pmd-main.xml            test-classes
cobertura                      pmd-test.xml
generated-classes              pmd.xml
✔ 22:01 ~/work/workspace/sevntu.checkstyle/sevntu-checks [master|✔] $ zipinfo target/sevntu-checks-1.34.1.jar | grep 'lib/.*jar'
✘-1 22:02 ~/work/workspace/sevntu.checkstyle/sevntu-checks [master|✔] $ zipinfo target/sevntu-checks-1.34.1.jar
Archive:  target/sevntu-checks-1.34.1.jar
Zip file size: 195748 bytes, number of entries: 104
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 META-INF/
-rw-r--r--  2.0 unx      136 b- defN 19-Jul-05 21:53 META-INF/MANIFEST.MF
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/sizes/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/naming/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/annotation/
-rw-rw-r--  2.0 unx     4672 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheck.class
-rw-rw-r--  2.0 unx     6366 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/ChildBlockLengthCheck.class
-rw-rw-r--  2.0 unx     2519 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheck.class
-rw-rw-r--  2.0 unx     1309 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/messages.properties
-rw-rw-r--  2.0 unx     1613 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/NestedSwitchCheck.class
-rw-rw-r--  2.0 unx     2037 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$2.class
-rw-rw-r--  2.0 unx     5823 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheck.class
-rw-rw-r--  2.0 unx    15223 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck.class
-rw-rw-r--  2.0 unx     8859 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/ForbidWildcardAsReturnTypeCheck.class
-rw-rw-r--  2.0 unx     1651 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame$2.class
-rw-rw-r--  2.0 unx     4608 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/NoMainMethodInAbstractClassCheck.class
-rw-rw-r--  2.0 unx     1635 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$1.class
-rw-rw-r--  2.0 unx     7869 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/CheckstyleTestMakeupCheck.class
-rw-rw-r--  2.0 unx     5540 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheck.class
-rw-rw-r--  2.0 unx     6225 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame.class
-rw-rw-r--  2.0 unx     1623 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/InnerClassCheck.class
-rw-rw-r--  2.0 unx     2701 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/HideUtilityClassConstructorCheck.class
-rw-rw-r--  2.0 unx     1640 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame$1.class
-rw-rw-r--  2.0 unx     4653 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/IllegalCatchExtendedCheck.class
-rw-rw-r--  2.0 unx     4208 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.class
-rw-rw-r--  2.0 unx     4992 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ConfusingConditionCheck.class
-rw-rw-r--  2.0 unx    12092 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/MapIterationInForEachLoopCheck.class
-rw-rw-r--  2.0 unx     3743 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ParameterJsr305Handler.class
-rw-rw-r--  2.0 unx     5269 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/UnnecessaryParenthesesExtendedCheck.class
-rw-rw-r--  2.0 unx     1943 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/SingleBreakOrContinueCheck.class
-rw-rw-r--  2.0 unx     2445 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/MoveVariableInsideIfCheck$Holder.class
-rw-rw-r--  2.0 unx     7814 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheck.class
-rw-rw-r--  2.0 unx    18521 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck.class
-rw-rw-r--  2.0 unx     2006 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ClassJsr305Handler.class
-rw-rw-r--  2.0 unx     4761 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidCertainMethodCheck.class
-rw-rw-r--  2.0 unx     8717 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/messages.properties
-rw-rw-r--  2.0 unx     2524 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidCertainMethodCheck$IntRange.class
-rw-rw-r--  2.0 unx     3434 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/UselessSuperCtorCallCheck.class
-rw-rw-r--  2.0 unx     1133 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$1.class
-rw-rw-r--  2.0 unx     2927 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/MultipleVariableDeclarationsExtendedCheck.class
-rw-rw-r--  2.0 unx     5451 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/SimpleAccessorNameNotationCheck.class
-rw-rw-r--  2.0 unx     3591 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheck.class
-rw-rw-r--  2.0 unx     2473 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/WhitespaceBeforeArrayInitializerCheck.class
-rw-rw-r--  2.0 unx     6270 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ReturnCountExtendedCheck.class
-rw-rw-r--  2.0 unx     5141 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.class
-rw-rw-r--  2.0 unx     8152 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheck.class
-rw-rw-r--  2.0 unx     2211 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidCCommentsInMethodsCheck.class
-rw-rw-r--  2.0 unx     4931 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$ClassDetail.class
-rw-rw-r--  2.0 unx     1557 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck$NumericType.class
-rw-rw-r--  2.0 unx     2872 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$NullnessAnnotation.class
-rw-rw-r--  2.0 unx     3965 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/MoveVariableInsideIfCheck.class
-rw-rw-r--  2.0 unx     2563 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheck.class
-rw-rw-r--  2.0 unx     1693 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ReturnBooleanFromTernaryCheck.class
-rw-rw-r--  2.0 unx     2069 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$AbstractMethodJsr305Handler.class
-rw-rw-r--  2.0 unx     2336 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$FormatMatcher.class
-rw-rw-r--  2.0 unx     2932 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidReturnInFinallyBlockCheck.class
-rw-rw-r--  2.0 unx     7678 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/NoNullForCollectionReturnCheck.class
-rw-rw-r--  2.0 unx     4958 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/MultipleStringLiteralsExtendedCheck.class
-rw-rw-r--  2.0 unx     4607 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/AvoidNotShortCircuitOperatorsForBooleanCheck.class
-rw-rw-r--  2.0 unx      300 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$1.class
-rw-rw-r--  2.0 unx     1570 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck$SiblingIterator.class
-rw-rw-r--  2.0 unx     8701 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.class
-rw-rw-r--  2.0 unx     6360 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$AbstractJsr305Handler.class
-rw-rw-r--  2.0 unx     4005 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidThrowAnonymousExceptionsCheck.class
-rw-rw-r--  2.0 unx     5842 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheck.class
-rw-rw-r--  2.0 unx     3151 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/LogicConditionNeedOptimizationCheck.class
-rw-rw-r--  2.0 unx     2425 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/UselessSingleCatchCheck.class
-rw-rw-r--  2.0 unx     3781 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$MethodJsr305Handler.class
-rw-rw-r--  2.0 unx     4552 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/NameConventionForJunit4TestClassesCheck.class
-rw-rw-r--  2.0 unx     1885 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ConstructorJsr305Handler.class
-rw-rw-r--  2.0 unx     4121 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheck.class
-rw-rw-r--  2.0 unx     2982 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/AvoidConstantAsFirstOperandInConditionCheck.class
-rw-rw-r--  2.0 unx     8953 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/EitherLogOrThrowCheck.class
-rw-rw-r--  2.0 unx     2819 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/DiamondOperatorForVariableDefinitionCheck.class
-rw-rw-r--  2.0 unx     4813 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/TernaryPerExpressionCountCheck.class
-rw-rw-r--  2.0 unx     4100 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheck.class
-rw-rw-r--  2.0 unx    12698 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck.class
-rw-rw-r--  2.0 unx    12107 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck.class
-rw-rw-r--  2.0 unx     4990 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheck.class
-rw-rw-r--  2.0 unx     1481 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck$OverridableMetCall.class
-rw-rw-r--  2.0 unx      105 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/sizes/messages.properties
-rw-rw-r--  2.0 unx     4448 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheck.class
-rw-rw-r--  2.0 unx     1237 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/naming/InterfaceTypeParameterNameCheck.class
-rw-rw-r--  2.0 unx      239 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/naming/messages.properties
-rw-rw-r--  2.0 unx     1069 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/naming/EnumValueNameCheck.class
-rw-rw-r--  2.0 unx     4300 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheck.class
-rw-rw-r--  2.0 unx     3188 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationCheck.class
-rw-rw-r--  2.0 unx      253 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/annotation/messages.properties
-rw-rw-r--  2.0 unx     3971 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/annotation/RequiredParameterForAnnotationCheck.class
-rw-rw-r--  2.0 unx     6308 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationElementValueCheck.class
-rw-rw-r--  2.0 unx     1490 b- defN 19-Jul-05 21:53 com/github/sevntu/checkstyle/SevntuUtil.class
-rw-rw-r--  2.0 unx      488 b- defN 19-Jul-05 21:53 checkstyle_packages.xml
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-05 21:53 META-INF/maven/
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-05 21:53 META-INF/maven/com.github.sevntu-checkstyle/
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-05 21:53 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checks/
-rw-rw-r--  2.0 unx    17430 b- defN 19-Jul-03 23:26 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checks/pom.xml
-rw-rw-r--  2.0 unx      127 b- defN 19-Jul-05 21:53 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checks/pom.properties
104 files, 394970 bytes uncompressed, 172904 bytes compressed:  56.2%

Checkstyle library goes as a transitive dependency in other projects which use sevntu-checks. I'll go through the rest of the projects and try to exclude checkstyle library explicitly (same as for sevntu-sonar). List of projects to check:

~/work/workspace/sevntu.checkstyle [master|✔] $ grep -irn "<artifactId>sevntu-checks<" --include='pom.xml' .
./sevntu-checks/pom.xml:13:  <artifactId>sevntu-checks</artifactId>
./sevntu-checks/pom.xml:409:                <artifactId>sevntu-checks</artifactId>
./sevntu-checkstyle-sonar-plugin/pom.xml:42:      <artifactId>sevntu-checks</artifactId>
./sevntu-checkstyle-idea-extension/pom.xml:29:      <artifactId>sevntu-checks</artifactId>
./sevntu-checkstyle-idea-extension/pom.xml:105:                  <artifactId>sevntu-checks</artifactId>
./eclipsecs-sevntu-plugin/pom.xml:35:      <artifactId>sevntu-checks</artifactId>
./eclipsecs-sevntu-plugin/pom.xml:89:                  <artifactId>sevntu-checks</artifactId>
./sevntu-checkstyle-maven-plugin/pom.xml:27:      <artifactId>sevntu-checks</artifactId>
  • sevntu-checkstyle-idea-extension
  • eclipsecs-sevntu-plugin
  • sevntu-checkstyle-maven-plugin
@rnveach

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Looks like sevntu-checks doesn't bundle checkstyle library.

If that was the case, we wouldn't need the exclusion in sonar at https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checkstyle-sonar-plugin/pom.xml#L44 .
We have the dependency in sevntu-checks at https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L36-L40 . I assume since it isn't listed as <scope>provided</scope> it is being bundled into maven and any all jar.

@rdiachenko

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

@rnveach you are right, I got 'bundle' interpreted wrong. Just built sevntu-checks with checkstyle in 'provided' scope and rebult sevntu-sonar plugin without exclusion. Works fine, checkstyle dependency is not present in the resulted jar of sevntu-sonar plugin.

@rdiachenko

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

sevntu-checkstyle-idea-extension doesn't include checkstyle jar

~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-idea-extension [issue-758] $ ls target/
apidocs                          maven-archiver
classes                          sevntu-checkstyle-idea-extension-1.34.1.jar
dependency-maven-plugin-markers  sevntu-checkstyle-idea-extension-1.34.1-javadoc.jar
javadoc-bundle-options           sevntu-checkstyle-idea-extension-1.34.1-sources.jar
~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-idea-extension [issue-758] $ zipinfo target/sevntu-checkstyle-idea-extension-1.34.1.jar | grep 'lib/.*jar'
~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-idea-extension [issue-758] $ zipinfo target/sevntu-checkstyle-idea-extension-1.34.1.jar
Archive:  target/sevntu-checkstyle-idea-extension-1.34.1.jar
Zip file size: 220353 bytes, number of entries: 114
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 META-INF/
-rw-r--r--  2.0 unx      136 b- defN 19-Jul-08 21:47 META-INF/MANIFEST.MF
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/design/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/coding/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/sizes/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/naming/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/annotation/
-rw-rw-r--  2.0 unx     4672 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheck.class
-rw-rw-r--  2.0 unx     6366 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/ChildBlockLengthCheck.class
-rw-rw-r--  2.0 unx     8436 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/design/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx     2519 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheck.class
-rw-rw-r--  2.0 unx     1309 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/messages.properties
-rw-rw-r--  2.0 unx     1613 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/NestedSwitchCheck.class
-rw-rw-r--  2.0 unx     2037 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$2.class
-rw-rw-r--  2.0 unx     5823 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheck.class
-rw-rw-r--  2.0 unx    15223 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck.class
-rw-rw-r--  2.0 unx     8859 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/ForbidWildcardAsReturnTypeCheck.class
-rw-rw-r--  2.0 unx     1651 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame$2.class
-rw-rw-r--  2.0 unx     4608 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/NoMainMethodInAbstractClassCheck.class
-rw-rw-r--  2.0 unx     1635 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$1.class
-rw-rw-r--  2.0 unx     7869 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/CheckstyleTestMakeupCheck.class
-rw-rw-r--  2.0 unx     5540 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheck.class
-rw-rw-r--  2.0 unx     6225 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame.class
-rw-rw-r--  2.0 unx    10442 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/design/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     1623 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/InnerClassCheck.class
-rw-rw-r--  2.0 unx     2701 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/HideUtilityClassConstructorCheck.class
-rw-rw-r--  2.0 unx     1640 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame$1.class
-rw-rw-r--  2.0 unx     4653 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/IllegalCatchExtendedCheck.class
-rw-rw-r--  2.0 unx     4208 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.class
-rw-rw-r--  2.0 unx     4992 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ConfusingConditionCheck.class
-rw-rw-r--  2.0 unx    12092 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/MapIterationInForEachLoopCheck.class
-rw-rw-r--  2.0 unx     3743 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ParameterJsr305Handler.class
-rw-rw-r--  2.0 unx     5269 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/UnnecessaryParenthesesExtendedCheck.class
-rw-rw-r--  2.0 unx     1943 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/SingleBreakOrContinueCheck.class
-rw-rw-r--  2.0 unx     2445 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/MoveVariableInsideIfCheck$Holder.class
-rw-rw-r--  2.0 unx     7814 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheck.class
-rw-rw-r--  2.0 unx    43307 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/coding/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx    18521 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck.class
-rw-rw-r--  2.0 unx     2006 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ClassJsr305Handler.class
-rw-rw-r--  2.0 unx     4761 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidCertainMethodCheck.class
-rw-rw-r--  2.0 unx     8717 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/messages.properties
-rw-rw-r--  2.0 unx     2524 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidCertainMethodCheck$IntRange.class
-rw-rw-r--  2.0 unx     3434 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/UselessSuperCtorCallCheck.class
-rw-rw-r--  2.0 unx     1133 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$1.class
-rw-rw-r--  2.0 unx     2927 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/MultipleVariableDeclarationsExtendedCheck.class
-rw-rw-r--  2.0 unx     5451 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/SimpleAccessorNameNotationCheck.class
-rw-rw-r--  2.0 unx     3591 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheck.class
-rw-rw-r--  2.0 unx     2473 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/WhitespaceBeforeArrayInitializerCheck.class
-rw-rw-r--  2.0 unx     6270 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ReturnCountExtendedCheck.class
-rw-rw-r--  2.0 unx     5141 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.class
-rw-rw-r--  2.0 unx     8152 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheck.class
-rw-rw-r--  2.0 unx     2211 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidCCommentsInMethodsCheck.class
-rw-rw-r--  2.0 unx     4931 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$ClassDetail.class
-rw-rw-r--  2.0 unx     1557 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck$NumericType.class
-rw-rw-r--  2.0 unx     2872 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$NullnessAnnotation.class
-rw-rw-r--  2.0 unx     3965 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/MoveVariableInsideIfCheck.class
-rw-rw-r--  2.0 unx     2563 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheck.class
-rw-rw-r--  2.0 unx     1693 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ReturnBooleanFromTernaryCheck.class
-rw-rw-r--  2.0 unx     2069 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$AbstractMethodJsr305Handler.class
-rw-rw-r--  2.0 unx     2336 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$FormatMatcher.class
-rw-rw-r--  2.0 unx     2932 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidReturnInFinallyBlockCheck.class
-rw-rw-r--  2.0 unx     7678 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/NoNullForCollectionReturnCheck.class
-rw-rw-r--  2.0 unx     4958 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/MultipleStringLiteralsExtendedCheck.class
-rw-rw-r--  2.0 unx     4607 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/AvoidNotShortCircuitOperatorsForBooleanCheck.class
-rw-rw-r--  2.0 unx      300 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$1.class
-rw-rw-r--  2.0 unx     1570 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck$SiblingIterator.class
-rw-rw-r--  2.0 unx     8701 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.class
-rw-rw-r--  2.0 unx     6360 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$AbstractJsr305Handler.class
-rw-rw-r--  2.0 unx     4005 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidThrowAnonymousExceptionsCheck.class
-rw-rw-r--  2.0 unx     5842 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheck.class
-rw-rw-r--  2.0 unx     3151 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/LogicConditionNeedOptimizationCheck.class
-rw-rw-r--  2.0 unx     2425 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/UselessSingleCatchCheck.class
-rw-rw-r--  2.0 unx     3781 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$MethodJsr305Handler.class
-rw-rw-r--  2.0 unx     4552 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/NameConventionForJunit4TestClassesCheck.class
-rw-rw-r--  2.0 unx     1885 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ConstructorJsr305Handler.class
-rw-rw-r--  2.0 unx     4121 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheck.class
-rw-rw-r--  2.0 unx    37439 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/coding/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     2982 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/AvoidConstantAsFirstOperandInConditionCheck.class
-rw-rw-r--  2.0 unx     8953 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/EitherLogOrThrowCheck.class
-rw-rw-r--  2.0 unx     2819 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/DiamondOperatorForVariableDefinitionCheck.class
-rw-rw-r--  2.0 unx     4813 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/TernaryPerExpressionCountCheck.class
-rw-rw-r--  2.0 unx     4100 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheck.class
-rw-rw-r--  2.0 unx    12698 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck.class
-rw-rw-r--  2.0 unx    12107 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck.class
-rw-rw-r--  2.0 unx     4990 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheck.class
-rw-rw-r--  2.0 unx     1481 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck$OverridableMetCall.class
-rw-rw-r--  2.0 unx      749 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/sizes/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx      105 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/sizes/messages.properties
-rw-rw-r--  2.0 unx     4448 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheck.class
-rw-rw-r--  2.0 unx     1775 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/sizes/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     1237 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/naming/InterfaceTypeParameterNameCheck.class
-rw-rw-r--  2.0 unx      857 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/naming/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx      239 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/naming/messages.properties
-rw-rw-r--  2.0 unx     1069 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/naming/EnumValueNameCheck.class
-rw-rw-r--  2.0 unx     2095 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/naming/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     4300 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheck.class
-rw-rw-r--  2.0 unx     3188 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationCheck.class
-rw-rw-r--  2.0 unx     3103 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/annotation/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx      253 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/annotation/messages.properties
-rw-rw-r--  2.0 unx     3971 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/annotation/RequiredParameterForAnnotationCheck.class
-rw-rw-r--  2.0 unx     6308 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationElementValueCheck.class
-rw-rw-r--  2.0 unx     3525 b- defN 19-Jul-08 21:47 com/github/sevntu/checkstyle/checks/annotation/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     1490 b- defN 19-Jul-08 21:43 com/github/sevntu/checkstyle/SevntuUtil.class
-rw-rw-r--  2.0 unx      687 b- defN 19-Jul-08 21:47 checkstyle_packages.xml
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-08 21:47 META-INF/maven/
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-08 21:47 META-INF/maven/com.github.sevntu-checkstyle/
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-08 21:47 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-idea-extension/
-rw-rw-r--  2.0 unx     4874 b- defN 19-Jun-30 22:32 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-idea-extension/pom.xml
-rw-rw-r--  2.0 unx      146 b- defN 19-Jul-08 21:47 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-idea-extension/pom.properties
114 files, 494360 bytes uncompressed, 195233 bytes compressed:  60.5%

I also compared resulted jars with provided and compile checkstyle scope in sevntu-checks:
idea-compile-provided-cmp

~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-idea-extension/tmp [issue-758] $ diff compile/META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-idea-extension/pom.properties provided/META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-idea-extension/pom.properties 
2c2
< #Mon Jul 08 21:47:42 BST 2019
---
> #Mon Jul 08 21:56:15 BST 2019
@rdiachenko

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

eclipsecs-sevntu-plugin doesn't include checkstyle jar

~/work/workspace/sevntu.checkstyle [issue-758] $ zipinfo ~/.m2/repository/com/github/sevntu-checkstyle/eclipsecs-sevntu-plugin/1.34.1/eclipsecs-sevntu-plugin-1.34.1.jar | grep 'lib/.*jar'
~/work/workspace/sevntu.checkstyle [issue-758] $ zipinfo ~/.m2/repository/com/github/sevntu-checkstyle/eclipsecs-sevntu-plugin/1.34.1/eclipsecs-sevntu-plugin-1.34.1.jar
Archive:  /home/rdiachenko/.m2/repository/com/github/sevntu-checkstyle/eclipsecs-sevntu-plugin/1.34.1/eclipsecs-sevntu-plugin-1.34.1.jar
Zip file size: 220379 bytes, number of entries: 115
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 META-INF/
-rw-r--r--  2.0 unx      536 b- defN 19-Jul-08 22:23 META-INF/MANIFEST.MF
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/design/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/coding/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/sizes/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/naming/
drwxrwxr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/annotation/
-rw-rw-r--  2.0 unx     4672 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/AvoidConditionInversionCheck.class
-rw-rw-r--  2.0 unx     6366 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/ChildBlockLengthCheck.class
-rw-rw-r--  2.0 unx     8436 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/design/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx     2519 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/ConstructorWithoutParamsCheck.class
-rw-rw-r--  2.0 unx     1309 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/messages.properties
-rw-rw-r--  2.0 unx     1613 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/NestedSwitchCheck.class
-rw-rw-r--  2.0 unx     2037 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$2.class
-rw-rw-r--  2.0 unx     5823 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/PublicReferenceToPrivateTypeCheck.class
-rw-rw-r--  2.0 unx    15223 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck.class
-rw-rw-r--  2.0 unx     8859 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/ForbidWildcardAsReturnTypeCheck.class
-rw-rw-r--  2.0 unx     1651 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame$2.class
-rw-rw-r--  2.0 unx     4608 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/NoMainMethodInAbstractClassCheck.class
-rw-rw-r--  2.0 unx     1635 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$1.class
-rw-rw-r--  2.0 unx     7869 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/CheckstyleTestMakeupCheck.class
-rw-rw-r--  2.0 unx     5540 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/CauseParameterInExceptionCheck.class
-rw-rw-r--  2.0 unx     6225 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame.class
-rw-rw-r--  2.0 unx    10442 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/design/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     1623 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/InnerClassCheck.class
-rw-rw-r--  2.0 unx     2701 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/HideUtilityClassConstructorCheck.class
-rw-rw-r--  2.0 unx     1640 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/design/StaticMethodCandidateCheck$Frame$1.class
-rw-rw-r--  2.0 unx     4653 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/IllegalCatchExtendedCheck.class
-rw-rw-r--  2.0 unx     4208 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck.class
-rw-rw-r--  2.0 unx     4992 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ConfusingConditionCheck.class
-rw-rw-r--  2.0 unx    12092 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/MapIterationInForEachLoopCheck.class
-rw-rw-r--  2.0 unx     3743 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ParameterJsr305Handler.class
-rw-rw-r--  2.0 unx     5269 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/UnnecessaryParenthesesExtendedCheck.class
-rw-rw-r--  2.0 unx     1943 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/SingleBreakOrContinueCheck.class
-rw-rw-r--  2.0 unx     2445 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/MoveVariableInsideIfCheck$Holder.class
-rw-rw-r--  2.0 unx     7814 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/AvoidModifiersForTypesCheck.class
-rw-rw-r--  2.0 unx    43307 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/coding/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx    18521 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck.class
-rw-rw-r--  2.0 unx     2006 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ClassJsr305Handler.class
-rw-rw-r--  2.0 unx     4761 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidCertainMethodCheck.class
-rw-rw-r--  2.0 unx     8717 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/messages.properties
-rw-rw-r--  2.0 unx     2524 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidCertainMethodCheck$IntRange.class
-rw-rw-r--  2.0 unx     3434 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/UselessSuperCtorCallCheck.class
-rw-rw-r--  2.0 unx     1133 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$1.class
-rw-rw-r--  2.0 unx     2927 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/MultipleVariableDeclarationsExtendedCheck.class
-rw-rw-r--  2.0 unx     5451 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/SimpleAccessorNameNotationCheck.class
-rw-rw-r--  2.0 unx     3591 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheck.class
-rw-rw-r--  2.0 unx     2473 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/WhitespaceBeforeArrayInitializerCheck.class
-rw-rw-r--  2.0 unx     6270 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ReturnCountExtendedCheck.class
-rw-rw-r--  2.0 unx     5141 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.class
-rw-rw-r--  2.0 unx     8152 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/EmptyPublicCtorInClassCheck.class
-rw-rw-r--  2.0 unx     2211 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidCCommentsInMethodsCheck.class
-rw-rw-r--  2.0 unx     4931 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$ClassDetail.class
-rw-rw-r--  2.0 unx     1557 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck$NumericType.class
-rw-rw-r--  2.0 unx     2872 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$NullnessAnnotation.class
-rw-rw-r--  2.0 unx     3965 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/MoveVariableInsideIfCheck.class
-rw-rw-r--  2.0 unx     2563 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ReturnNullInsteadOfBooleanCheck.class
-rw-rw-r--  2.0 unx     1693 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ReturnBooleanFromTernaryCheck.class
-rw-rw-r--  2.0 unx     2069 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$AbstractMethodJsr305Handler.class
-rw-rw-r--  2.0 unx     2336 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/CustomDeclarationOrderCheck$FormatMatcher.class
-rw-rw-r--  2.0 unx     2932 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidReturnInFinallyBlockCheck.class
-rw-rw-r--  2.0 unx     7678 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/NoNullForCollectionReturnCheck.class
-rw-rw-r--  2.0 unx     4958 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/MultipleStringLiteralsExtendedCheck.class
-rw-rw-r--  2.0 unx     4607 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/AvoidNotShortCircuitOperatorsForBooleanCheck.class
-rw-rw-r--  2.0 unx      300 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$1.class
-rw-rw-r--  2.0 unx     1570 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/AvoidDefaultSerializableInInnerClassesCheck$SiblingIterator.class
-rw-rw-r--  2.0 unx     8701 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.class
-rw-rw-r--  2.0 unx     6360 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$AbstractJsr305Handler.class
-rw-rw-r--  2.0 unx     4005 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidThrowAnonymousExceptionsCheck.class
-rw-rw-r--  2.0 unx     5842 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/RedundantReturnCheck.class
-rw-rw-r--  2.0 unx     3151 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/LogicConditionNeedOptimizationCheck.class
-rw-rw-r--  2.0 unx     2425 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/UselessSingleCatchCheck.class
-rw-rw-r--  2.0 unx     3781 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$MethodJsr305Handler.class
-rw-rw-r--  2.0 unx     4552 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/NameConventionForJunit4TestClassesCheck.class
-rw-rw-r--  2.0 unx     1885 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck$ConstructorJsr305Handler.class
-rw-rw-r--  2.0 unx     4121 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheck.class
-rw-rw-r--  2.0 unx    37439 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/coding/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     2982 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/AvoidConstantAsFirstOperandInConditionCheck.class
-rw-rw-r--  2.0 unx     8953 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/EitherLogOrThrowCheck.class
-rw-rw-r--  2.0 unx     2819 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/DiamondOperatorForVariableDefinitionCheck.class
-rw-rw-r--  2.0 unx     4813 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/TernaryPerExpressionCountCheck.class
-rw-rw-r--  2.0 unx     4100 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidCertainImportsCheck.class
-rw-rw-r--  2.0 unx    12698 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck.class
-rw-rw-r--  2.0 unx    12107 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/Jsr305AnnotationsCheck.class
-rw-rw-r--  2.0 unx     4990 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/ForbidInstantiationCheck.class
-rw-rw-r--  2.0 unx     1481 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheck$OverridableMetCall.class
-rw-rw-r--  2.0 unx      749 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/sizes/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx      105 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/sizes/messages.properties
-rw-rw-r--  2.0 unx     4448 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/sizes/LineLengthExtendedCheck.class
-rw-rw-r--  2.0 unx     1775 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/sizes/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     1237 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/naming/InterfaceTypeParameterNameCheck.class
-rw-rw-r--  2.0 unx      857 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/naming/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx      239 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/naming/messages.properties
-rw-rw-r--  2.0 unx     1069 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/naming/EnumValueNameCheck.class
-rw-rw-r--  2.0 unx     2095 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/naming/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     4300 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/naming/UniformEnumConstantNameCheck.class
-rw-rw-r--  2.0 unx     3188 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationCheck.class
-rw-rw-r--  2.0 unx     3103 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/annotation/checkstyle-metadata.properties
-rw-rw-r--  2.0 unx      253 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/annotation/messages.properties
-rw-rw-r--  2.0 unx     3971 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/annotation/RequiredParameterForAnnotationCheck.class
-rw-rw-r--  2.0 unx     6308 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/checks/annotation/ForbidAnnotationElementValueCheck.class
-rw-rw-r--  2.0 unx     3525 b- defN 19-Jul-08 22:23 com/github/sevntu/checkstyle/checks/annotation/checkstyle-metadata.xml
-rw-rw-r--  2.0 unx     1490 b- defN 19-Jul-08 22:10 com/github/sevntu/checkstyle/SevntuUtil.class
-rw-rw-r--  2.0 unx      687 b- defN 19-Jul-08 22:23 checkstyle_packages.xml
-rw-rw-r--  2.0 unx      213 b- defN 19-Jun-30 22:28 plugin.xml
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 META-INF/maven/
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 META-INF/maven/com.github.sevntu-checkstyle/
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-08 22:23 META-INF/maven/com.github.sevntu-checkstyle/eclipsecs-sevntu-plugin/
-rw-rw-r--  2.0 unx     3354 b- defN 19-Jun-30 22:32 META-INF/maven/com.github.sevntu-checkstyle/eclipsecs-sevntu-plugin/pom.xml
-rw-rw-r--  2.0 unx      137 b- defN 19-Jul-08 22:23 META-INF/maven/com.github.sevntu-checkstyle/eclipsecs-sevntu-plugin/pom.properties
115 files, 493444 bytes uncompressed, 195217 bytes compressed:  60.4%

Compared resulted jars with provided and compile checkstyle scope in sevntu-checks:
eclipse-compile-provided-cmp

~/work/workspace/sevntu.checkstyle/tmp [issue-758] $ diff compile/META-INF/maven/com.github.sevntu-checkstyle/eclipsecs-sevntu-plugin/pom.properties provided/META-INF/maven/com.github.sevntu-checkstyle/eclipsecs-sevntu-plugin/pom.properties 
2c2
< #Mon Jul 08 22:23:32 BST 2019
---
> #Mon Jul 08 22:31:15 BST 2019
@rdiachenko

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

sevntu-checkstyle-maven-plugin doesn't include checkstyle jar

~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-maven-plugin [issue-758] $ ls target/
classes                 maven-archiver                             sevntu-checkstyle-maven-plugin-1.34.1-sources.jar
javadoc-bundle-options  sevntu-checkstyle-maven-plugin-1.34.1.jar
~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-maven-plugin [issue-758] $ zipinfo target/sevntu-checkstyle-maven-plugin-1.34.1.jar | grep 'lib/.*jar'
~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-maven-plugin [issue-758] $ zipinfo target/sevntu-checkstyle-maven-plugin-1.34.1.jar
Archive:  target/sevntu-checkstyle-maven-plugin-1.34.1.jar
Zip file size: 2914 bytes, number of entries: 8
drwxr-xr-x  2.0 unx        0 b- stor 19-Jul-08 22:38 META-INF/
-rw-r--r--  2.0 unx      136 b- defN 19-Jul-08 22:38 META-INF/MANIFEST.MF
-rw-rw-r--  2.0 unx     1097 b- defN 19-Jul-08 22:38 checkstyle_packages.xml
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-08 22:38 META-INF/maven/
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-08 22:38 META-INF/maven/com.github.sevntu-checkstyle/
?rwsrwsrwt  2.0 unx        0 b- stor 19-Jul-08 22:38 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-maven-plugin/
-rw-rw-r--  2.0 unx     3644 b- defN 19-Jul-03 23:26 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-maven-plugin/pom.xml
-rw-rw-r--  2.0 unx      144 b- defN 19-Jul-08 22:38 META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-maven-plugin/pom.properties
8 files, 5021 bytes uncompressed, 1570 bytes compressed:  68.7%

Compared resulted jars with provided and compile checkstyle scope in sevntu-checks:
maven-compile-provided-cmp

~/work/workspace/sevntu.checkstyle/sevntu-checkstyle-maven-plugin/tmp [issue-758] $ diff compile/META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-maven-plugin/pom.properties provided/META-INF/maven/com.github.sevntu-checkstyle/sevntu-checkstyle-maven-plugin/pom.properties 
2c2
< #Mon Jul 08 22:38:24 BST 2019
---
> #Mon Jul 08 22:44:08 BST 2019

rdiachenko added a commit to rdiachenko/sevntu.checkstyle that referenced this issue Jul 8, 2019

@rdiachenko

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

To summarize, checkstyle jar is not included in resulted jars of sevntu extensions but it is present in maven dependency tree as a transitive dependency for each extension.

The scope of checkstyle dependency inside sevntu-checks will be changed from compile to provided. This update means the following:

  • sevntu-checkstyle-idea-extension - nothing changes, the extension will continue using checkstyle dependency provided by the main plugin
  • eclipsecs-sevntu-plugin - nothing changes, the extension will continue using checkstyle dependency provided by the main plugin
  • sevntu-checkstyle-sonar-plugin (!!BREAKING COMPATIBILITY!!) - covers the fix in #746, the extension will start using checkstyle dependency provided by the main plugin. The extension will not work with the main plugin of version 4.21 or later. This is due to the broken compatibility in checkstyle 8.21
  • sevntu-checkstyle-maven-plugin (!!BREAKING COMPATIBILITY!!) - the extension will start using checkstyle dependency provided by the main plugin.
    MIGRATION NOTE: specify checkstyle version explicitly if default checkstyle provided by the main plugin doesn't work for you example of how to do it:
<plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>3.1.0</version>
        <dependencies>
          <dependency>
            <groupId>com.github.sevntu-checkstyle</groupId>
            <artifactId>sevntu-checkstyle-maven-plugin</artifactId>
            <version>1.34.1</version>
          </dependency>
          <dependency>
            <groupId>com.puppycrawl.tools</groupId>
            <artifactId>checkstyle</artifactId>
            <version>8.18</version>
          </dependency>
        </dependencies>
...
</plugin>
@romani

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

fix is merged

@romani romani closed this Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.