Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Check: NameConvensionForTests #80

Closed
romani opened this issue Nov 3, 2012 · 2 comments
Closed

New Check: NameConvensionForTests #80

romani opened this issue Nov 3, 2012 · 2 comments
Assignees
Labels

Comments

@romani
Copy link
Member

@romani romani commented Nov 3, 2012

Force Tests to follow naming convention.
Ground: maven do not run tests that are not following naming convention (http://stackoverflow.com/questions/6178583/maven-does-not-find-junit-tests-to-run).
Requirement: Force classes having unit tests to follow naming convention - class should be named "Test_", "_Test", "_TestCase" or "_IT" (the latter is for integration tests)
Criteria: Class is considered to have tests if it has methods annotated with "@test" or it extends other class that follows naming convention.

@ghost ghost assigned GeorgeSergeev Feb 7, 2013
@ghost ghost assigned denant0 Mar 18, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Sep 28, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Sep 28, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Sep 28, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Sep 30, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Oct 1, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Oct 3, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Oct 3, 2013
denant0 added a commit to denant0/sevntu.checkstyle that referenced this issue Oct 8, 2013
@daniilyar daniilyar added easy and removed enhancement labels Aug 15, 2014
@alex-zuy
Copy link
Contributor

@alex-zuy alex-zuy commented Sep 30, 2014

I think that current implementation is unfinished. I think that check should provide opportunity to configure set of annotations for class, methods and field definitions as separate options.
mClassAnnotationRegex - annotations for class definitions
mMethodAnnotationRegex - annotations for method definitions
mFieldAnnotationRegex - annotations for field definitions

@daniilyar
Copy link
Member

@daniilyar daniilyar commented Oct 3, 2014

I think that current implementation is unfinished
What does current implementation miss?

I think that check should provide opportunity to configure set of annotations for class, methods and field definitions as separate options.
I am not sure. Are you talking about JUnt4-related annotations only? What exact annotation do you presuppose and could you, please, give an examples for every option? I mean, please provide list of annotations (default values) for every option which, as you think, would be the best. We will discuss them.

alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Oct 10, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Oct 10, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Oct 10, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Oct 14, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Oct 14, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Oct 14, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Nov 28, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Nov 28, 2014
alex-zuy added a commit to alex-zuy/sevntu.checkstyle that referenced this issue Dec 3, 2014
@romani romani closed this in d2c4c45 Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.