Fixed #77. MapIterationInForEachLoop was introduced #172

Merged
merged 1 commit into from Mar 8, 2014

Conversation

Projects
None yet
4 participants
Member

maxvetrenko commented Mar 4, 2014

No description provided.

Member

maxvetrenko commented Mar 4, 2014

Yes, I have seen this fail, and I'll fix it in the evening

Owner

daniilyar commented Mar 4, 2014

Ok, please just do rebase with main repo

Member

maxvetrenko commented Mar 4, 2014

I have done rebase and now all is well

Owner

romani commented Mar 4, 2014

Daniil, please merge a PR.

Attention, as we do experiment with using that workflow for merge to let History to be more linear: https://github.com/wp-e-commerce/wp-e-commerce/wiki/Merging-Pull-Requests

Owner

daniilyar commented Mar 5, 2014

How could I merge if this code breaks UTs?

Failed tests: basicTest(com.github.sevntu.checkstyle.checks.coding.MapIterationInForEachLoopTest): error message 1 expected:<...InForEachLoop.java:4[5:13: You are using only values of this map. It is better to use values() to iterate this map].> but was:<...InForEachLoop.java:4[7:17: It is better to use keySet() method to iterate over this map because you aren`t using values].>

Owner

romani commented Mar 6, 2014

Strange, it show that "all is well"

Member

maxvetrenko commented Mar 6, 2014

BaseCheckTestSupport doesn't fail. It's very strange.

Member

maxvetrenko commented Mar 6, 2014

I done this PR to test my commit with Travis CI. We fixed bug in Unit Test class

daniilyar merged commit 474a5ef into sevntu-checkstyle:master Mar 8, 2014

1 check passed

default The Travis CI build passed
Details
Owner

daniilyar commented Mar 8, 2014

2 @maxvetrenko, Yes, it seems that unstable UT is now fixed. Merged to the main repo, congratulations!
I've been added you to the list of project contributors (as it was your first contribution to sevntu-checkstyle project): 01b5fec

maxvetrenko deleted the maxvetrenko:issue_77_MapIterationInForEachLoop branch Apr 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment