parallel_runtime_rspec.log incomplete

[der-flo]

When running specs in parallel combined with zeus, the parallel_runtime_rspec.log is incomplete, some lines are missing.

So e. g. bundle exec parallel_rspec spec/models results in a complete file, zeus parallel_rspec spec/models in an incomplete one.

I'm using the most recent versions of the gems:

• parallel_tests: 2.14.1
• zeus-parallel_tests: 0.3.1
• zeus: 0.15.13

[der-flo]

I suspect the implementation of Zeus::ParallelTests::Rails#spawn_slave is wrong regarding the setting of ENV['TEST_ENV_NUMBER']:

ENV['TEST_ENV_NUMBER'] = test_env_number = (worker == '1' ? nil : worker)

The worker-1 case should return '' instead of nil, at least ParallelTests::RSpec::RuntimeLogger#start_dump expects this. The Readme also mentions this.

@sevos, @schneidmaster: Opinions?

[pboling]

I believe you are correct. When ENV['TEST_ENV_NUMBER'] is nil logic based on it assumes you are not running in parallel. The fix is simple, and would be important for anything that needs to know if the spec suite is running in parallel (like logging, or a VCR library cleaner).