Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Problems with therubyracer #14

Closed
brandonweiss opened this Issue Oct 5, 2011 · 6 comments

Comments

Projects
None yet
3 participants

I'm having problems getting therubyracer to install, which of course is a problem with therubyracer or my machine, but I'm wondering why it's a necessary dependency? It wasn't previously. Also, I notice you truncated the commit history or something, so I can't pin to a previous version :(

Owner

seyhunak commented Oct 5, 2011

New version (1.3.0) uses Less and Less Railtie to work with Less CSS (Twitter Bootstrap built with Less).
So, as you know Rails 3.1 execjs requires JavaScript runtime therubyracer is required for it.
Just install execjs and therubyracer in your Gemfile and run bundle after.

Owner

seyhunak commented Oct 5, 2011

And you can install previous version (it's uses static CSS files) if you want
gem "twitter-bootstrap-rails", "~> 0.0.5"

@seyhunak seyhunak closed this Oct 7, 2011

Sorry, I should have phrased that better. I understand why you made it a dependency, I'm just not sure why it's necessary. therubyracer is kind of a heavy dependency for a CSS framework. Personally, it would seem to make more sense that the gem would serve the static assets, and then if you needed to compile them on the fly because you're modifying some of the colors or something, then you could manually require therubyracer. Just a thought.

I was actually pinned to a ref (that doesn't seem to exist any more) because at the time, the latest version on RubyGems (0.0.5) wasn't up to date with Bootstrap.

Owner

seyhunak commented Oct 8, 2011

I decided to create a seperate branch (w/o Less) that just serves latest static CSS, JS files.

You can install from latest build (from branch);
gem 'twitter-bootstrap-rails', :git => "git://github.com/seyhunak/twitter-bootstrap-rails.git", :branch => "static"
Please let me know if have any problems or suggestions.

That's perfect, man. Thanks so much!

Yes, perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment