Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated to support turbolinks for rails 4 with graceful fallback #400

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

This is replacing my previous pull request and restoring Readme.md / gemspec definitions. They were changed temporarily to get a gem out in the interim until this patch got out into the wild.

It allows for rails 4 turbolinks support, which is going to become standard. It also gracefully falls back and has no affect on sites that do not use turbolinks. It does require changing the twitter bootstrap source files themselves slightly. I will see about submitting these patches to twitter bootstrap repository itself in the future.

Thanks,
David

@davydotcom davydotcom referenced this pull request Oct 7, 2012

Closed

Turbolinks Support #399

Added pull request to main bootstrap branch, if anyone wants to vote it up :)
twitter/bootstrap#5445

Contributor

toadkicker commented Oct 7, 2012

I feel the point of this gem is to support Twitter Bootstrap more closely than Turbolinks. I want, at least for users of this gem, is to not have to worry that a modified version of bootstrap is being used. We may patch the bootstrap files for hotfixes and send pull requests to twitter, but eventually the gem is going to be 99.999% Bootstrap verbatim. This would be better served as a separate gem to be honest. One would be better served overriding bootstrap's methods to add this support instead of directly modifying bootstrap source.

Unfortunately with the way bootstrap initializes it's event handlers a direct modification had to be performed

Sent from my iPhone

On Oct 7, 2012, at 12:19 PM, toadkicker notifications@github.com wrote:

I feel the point of this gem is to support Twitter Bootstrap more closely than Turbolinks. I want, at least for users of this gem, is to not have to worry that a modified version of bootstrap is being used. We may patch the bootstrap files for hotfixes and send pull requests to twitter, but eventually the gem is going to be 99.999% Bootstrap verbatim. This would be better served as a separate gem to be honest. One would be better served overriding bootstrap's methods to add this support instead of directly modifying bootstrap source.


Reply to this email directly or view it on GitHub.

Contributor

toadkicker commented Feb 8, 2013

@seyhunak let's run a turbolinks branch and we can get a jump on handling rails 4 support?

Owner

seyhunak commented Feb 8, 2013

@toadkicker good idea.

I would really love this to work. I use twitter-bootstrap a lot and with rails 4 coming packed with turbolinks. It will be something I will have to find a work around for. I can't seem to find a reliable fix.

The jquery-turbolinks gem typically resolved bootstrap support

On Thursday, February 14, 2013, shoutsid wrote:

I would really love this to work. I use twitter-bootstrap a lot and with
rails 4 coming packed with turbolinks. It will be something I will have to
find a work around for. I can't seem to find a reliable fix.


Reply to this email directly or view it on GitHubhttps://github.com/seyhunak/twitter-bootstrap-rails/pull/400#issuecomment-13541854.

It doesn't seem to fix my menu, tried a few things. I don't want to make a
post anywhere just in case it's just something so simple which I've done.

On 14 February 2013 12:10, David Estes notifications@github.com wrote:

The jquery-turbolinks gem typically resolved bootstrap support

On Thursday, February 14, 2013, shoutsid wrote:

I would really love this to work. I use twitter-bootstrap a lot and with
rails 4 coming packed with turbolinks. It will be something I will have
to
find a work around for. I can't seem to find a reliable fix.


Reply to this email directly or view it on GitHub<
https://github.com/seyhunak/twitter-bootstrap-rails/pull/400#issuecomment-13541854>.


Reply to this email directly or view it on GitHubhttps://github.com/seyhunak/twitter-bootstrap-rails/pull/400#issuecomment-13544846.

I did make a bootstrap fork from this repo that I know worker at one point.
You can try that

On Thursday, February 14, 2013, shoutsid wrote:

It doesn't seem to fix my menu, tried a few things. I don't want to make a
post anywhere just in case it's just something so simple which I've done.

On 14 February 2013 12:10, David Estes <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>
wrote:

The jquery-turbolinks gem typically resolved bootstrap support

On Thursday, February 14, 2013, shoutsid wrote:

I would really love this to work. I use twitter-bootstrap a lot and
with
rails 4 coming packed with turbolinks. It will be something I will
have
to
find a work around for. I can't seem to find a reliable fix.


Reply to this email directly or view it on GitHub<

https://github.com/seyhunak/twitter-bootstrap-rails/pull/400#issuecomment-13541854>.


Reply to this email directly or view it on GitHub<
https://github.com/seyhunak/twitter-bootstrap-rails/pull/400#issuecomment-13544846>.


Reply to this email directly or view it on GitHubhttps://github.com/seyhunak/twitter-bootstrap-rails/pull/400#issuecomment-13546243.

@seyhunak seyhunak closed this Jun 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment