Fix broken relaxation #1762
Merged
Fix broken relaxation #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
minimal_output_size is only in one release, so I think we can just yank that release and remove the function. |
Sadly the condition used to relax output buffer checks that depended on the `num` parameter does not really hold so this change effectively reverts PR sfackler#1733. As clarified on the OpenSSL mailing list [0] and during integration tests the `num` parameter does not reflect the internal buffer cache size thus one needs to pessimistically assume that each call to `cipher_update` will need sufficient size to contain one additional block. Streaming ciphers are not affected by this revert. [0]: https://mta.openssl.org/pipermail/openssl-users/2022-December/015727.html
This mirrors the `Cipher::cipher_update_unchecked` API call for clients that want to manually track the state of internal OpenSSL cipher buffer size.
wiktor-k
force-pushed
the
fix-broken-relaxation
branch
from
6eb2ab1
to
45e5dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steven,
After a round of extensive integration testing and discussions on the OpenSSL mailing list it seems my "improvement" in #1733 was actually based on unsound promise. That is the
numparameter does not reflect the internal cache size (it's always zero and used only internally).I've basically reverted the old PR but kept the introduced function not to break the API (if you think it would be OK to remove
minimal_output_sizeor#[deprecate]it I'll adjust). As for my client code I'll build a safe API around*_uncheckedcalls by keeping the additional cache state in my structs.I'm super, super sorry for the annoyance I caused 🙇 I should've spent more time integration testing my previous PR but now I've caused you more trouble than necessary. Once again: my deepest apologies 🙏 !