Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some OpenSSL 3 QUIC raw bindings #2257

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add some OpenSSL 3 QUIC raw bindings #2257

merged 4 commits into from
Jul 3, 2024

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Jul 3, 2024

This PR mainly focuses on openssl-sys and raw bindings to OpenSSL 3 QUIC features that I think might be useful for implementing high-level, ergonomic QUIC bindings in openssl crate. Also fixed some minor issues when using bindgen feature with Windows MSVC.

Related: #2242

@bdbai bdbai marked this pull request as draft July 3, 2024 09:08
@bdbai bdbai marked this pull request as ready for review July 3, 2024 09:44
unsafe extern "C" fn(*mut SSL, *mut c_int, *mut libc::c_void) -> i32,
>,
std::option::Option<unsafe extern "C" fn()>,
>(cb),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to address the clippy errors thrown during the first commit’s CI checks: https://github.com/sfackler/rust-openssl/actions/runs/9774772847/job/26983758164

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfackler sfackler merged commit c38bc2f into sfackler:master Jul 3, 2024
61 checks passed
@bdbai bdbai deleted the quic branch July 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants