Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDoc asn1 module #743
Conversation
AndyGauge
added some commits
Sep 28, 2017
sfackler
reviewed
Sep 29, 2017
| @@ -88,10 +154,12 @@ impl Asn1StringRef { | |||
| } | |||
| } | |||
|
|
|||
| /// Return the string as an array of bytes | |||
This comment has been minimized.
This comment has been minimized.
sfackler
Sep 29, 2017
Owner
Can we note here that the bytes may not be in a standard UTF8 compatible encoding and point to as_utf8?
sfackler
reviewed
Sep 29, 2017
openssl/src/asn1.rs
Outdated
| @@ -137,7 +237,17 @@ foreign_type! { | |||
| type CType = ffi::ASN1_OBJECT; | |||
| fn drop = ffi::ASN1_OBJECT_free; | |||
|
|
|||
| /// Object Identifier | |||
| /// | |||
| /// Use OBJ_nid2obj() ffi to create objects, not Asn1Object directly. | |||
This comment has been minimized.
This comment has been minimized.
sfackler
merged commit 7159215
into
sfackler:master
Oct 1, 2017
12 of 13 checks passed
continuous-integration/appveyor/pr
AppVeyor build failed
Details
ci/circleci: armhf-openssl-1.0.1
Your tests passed on CircleCI!
Details
ci/circleci: armhf-openssl-1.0.2
Your tests passed on CircleCI!
Details
ci/circleci: armhf-openssl-1.1.0
Your tests passed on CircleCI!
Details
ci/circleci: i686-openssl-1.0.1
Your tests passed on CircleCI!
Details
ci/circleci: i686-openssl-1.0.2
Your tests passed on CircleCI!
Details
ci/circleci: i686-openssl-1.1.0
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-libressl-2.5.0
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-libressl-2.6.1
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-openssl-1.0.1
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-openssl-1.0.2
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-openssl-1.1.0
Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AndyGauge commentedSep 28, 2017
Fixes #699