Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDoc BigNum #744
Conversation
AndyGauge
added some commits
Sep 29, 2017
sfackler
reviewed
Oct 1, 2017
openssl/src/bn.rs
Outdated
| pub fn clear(&mut self) { | ||
| unsafe { ffi::BN_clear(self.as_ptr()) } | ||
| } | ||
|
|
||
| /// Adds a `u32` to `self`. | ||
| /// Adds a `u32` to `self`. OpenSSL documentation at [`BN_add_word`] |
This comment has been minimized.
This comment has been minimized.
sfackler
Oct 1, 2017
Owner
Can you put the documentation link in a separate paragraph for all of the methods here?
This comment has been minimized.
This comment has been minimized.
|
Looks good other than the one nit! |
sfackler
reviewed
Oct 4, 2017
openssl/src/bn.rs
Outdated
| @@ -665,55 +945,111 @@ impl BigNum { | |||
| } | |||
| } | |||
|
|
|||
| /// [`RFC 2409`] defines the Internet Key Exchange. The prime is in the order | |||
This comment has been minimized.
This comment has been minimized.
sfackler
Oct 4, 2017
Owner
The documentation here doesn't really tell me anything about what value I should expect to get from this function.
sfackler
merged commit 9d43fc6
into
sfackler:master
Oct 7, 2017
12 of 13 checks passed
continuous-integration/appveyor/pr
AppVeyor build failed
Details
ci/circleci: armhf-openssl-1.0.1
Your tests passed on CircleCI!
Details
ci/circleci: armhf-openssl-1.0.2
Your tests passed on CircleCI!
Details
ci/circleci: armhf-openssl-1.1.0
Your tests passed on CircleCI!
Details
ci/circleci: i686-openssl-1.0.1
Your tests passed on CircleCI!
Details
ci/circleci: i686-openssl-1.0.2
Your tests passed on CircleCI!
Details
ci/circleci: i686-openssl-1.1.0
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-libressl-2.5.0
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-libressl-2.6.1
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-openssl-1.0.1
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-openssl-1.0.2
Your tests passed on CircleCI!
Details
ci/circleci: x86_64-openssl-1.1.0
Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AndyGauge commentedSep 29, 2017
•
edited
Fixes #700