Encode Format based on Type #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Aug 15, 2022
tokio-postgres/src/query.rs
Outdated
| let (param_formats, params): (Vec<_>, Vec<_>) = params | ||
| .into_iter() | ||
| .map(|p| (p.borrow_to_sql().encode_format() as i16, p)) | ||
| .zip(param_types.iter()) |
There was a problem hiding this comment.
A zipped iterator stops as soon as the shortest iterator ends, so the length check below won't work properly. You may need to manually iterate.
There was a problem hiding this comment.
Would it be better (or sufficient) to move the length check before the zip to guard against the early-ending case?
There was a problem hiding this comment.
Oh yeah, we already require ExactSizeIterator so we can just move the assert.
There was a problem hiding this comment.
Great, updated in this commit.
|
I think you just need to rebase to fix the clippy error. LGTM otherwise! |
NAlexPear
force-pushed
the
encode_format_types
branch
from
4e0aaee
to
8158eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#836 has been helpful as a way of pairing parameter types with their encodings, but the
encode_formatmethod in theToSqltrait would be even more useful with the addition of a reference toType. This would enable more granular encoding of parameters based on the types inferred by Postgres during thepreparephase, which would be useful when processing payloads from more general type systems like gRPC or JSON.Since parameter types are already generated by the time
bind()is called, it's easy to include them as part of the format-generating process. This PR simply adds aTypeparameter to theencode_formatmethod added toToSql, which should not be a breaking change if it can be made before the next release.