Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSeveral fixes #1
+36
−24
Conversation
This comment has been minimized.
This comment has been minimized.
|
There are definitely more problems here, but this gets rid of the hanging. |
sfackler
merged commit d16f794
into
sfackler:master
May 10, 2016
brson
referenced this pull request
May 10, 2016
Merged
Don't panic when the NativeSslStream lock is poisoned #429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedMay 10, 2016
When there's data already buffered at entry to
readjust return it.Simple and correct. Maybe doesn't fix real bugs.
If the previous DecryptMessage resulted in SECBUFFER_DATA then
just run that data through DecryptMessage again before calling
read on the socket. This prevents read timeouts.
Add a 5th SecBuffer to the DecryptMessage calls, per MSDN.
Handle DecryptMessage errors.