Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a callback function to support Node.js v8 or later #2
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
lulzneko commentedMay 24, 2019
This is an extension pull request to support Node.js v10 or later.
The following error occurs when using ga-analytics with Node.js v10.
Processing without callback function of
fs.writeFile()API used bymodule.jshas been changed by upgrading Node.js.-v6: OK, no problem
-v8: Executable and deprecated logs are output
-v10: An error occurs
Passing a callback function to the
fs.writeFile()argument supports v10 and later.Thank you for the wonderful ga-analytics product.