Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a callback function to support Node.js v8 or later #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a callback function to support Node.js v8 or later #2

wants to merge 1 commit into from

Conversation

@lulzneko
Copy link

@lulzneko lulzneko commented May 24, 2019

This is an extension pull request to support Node.js v10 or later.

The following error occurs when using ga-analytics with Node.js v10.

Processing without callback function of fs.writeFile() API used by module.js has been changed by upgrading Node.js.
-v6: OK, no problem
-v8: Executable and deprecated logs are output
-v10: An error occurs

Passing a callback function to the fs.writeFile() argument supports v10 and later.

Thank you for the wonderful ga-analytics product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant