Skip to content

fix: [PRODUCT-604] build --start param of equivalent buy command correctly #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix: [PRODUCT-604] build --start param of equivalent buy command correctly #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions src/lib/extend/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import relativeTime from "npm:dayjs@1.11.13/plugin/relativeTime.js";
import boxen from "npm:boxen@8.0.1";
import console from "node:console";
import process from "node:process";
import ora from "ora";
import { getContractRange } from "../contracts/utils.ts";
import { apiClient } from "../../apiClient.ts";

dayjs.extend(relativeTime);
dayjs.extend(duration);
Expand Down Expand Up @@ -41,7 +44,7 @@ ${
boxen(
`\x1b[31m\x1b[97msf extend\x1b[31m is deprecated.\x1b[0m
\x1b[31mTo create, extend, and release specific machines directly, use \x1b[97msf nodes\x1b[31m.\x1b[0m
\x1b[31mTo "extend" a contract, use \x1b[97msf buy -colo <contract_id> -d <duration>\x1b[31m.\x1b[0m
\x1b[31mTo "extend" a contract, use \x1b[97msf buy -colo <contract_id> -s <contract_end_time> -d <duration>\x1b[31m.\x1b[0m
\x1b[31mHowever, contracts don't map to specific machines, so you can't choose which will persist.\x1b[0m
\x1b[31mWe strongly recommend using \x1b[97msf nodes\x1b[31m instead.\x1b[0m`,
{
Expand All @@ -52,10 +55,32 @@ ${
}
`,
)
.action(function extendAction(options) {
.action(async function extendAction(options) {
const spinner = ora().start(`Fetching contract ${options.contract}...`);
const api = await apiClient();

const { data: contract, response } = await api.GET("/v0/contracts/{id}", {
params: {
path: { id: options.contract },
},
});

const fetchFailed = !response.ok || !contract;
if (fetchFailed) {
spinner.fail(
`Failed to fetch contract ${options.contract}: ${response.statusText}`,
);
} else {
spinner.clear();
}

const contractRange = contract?.shape &&
getContractRange(contract?.shape);

// Build the equivalent sf buy command
let equivalentCommand =
`sf buy -colo ${options.contract} -d ${options.duration}`;
let equivalentCommand = `sf buy -colo ${options.contract} -s ${
contractRange?.endsAt?.toISOString?.() ?? "<contract_end_time>"
} -d ${options.duration}`;

if (options.price) {
equivalentCommand += ` -p ${options.price}`;
Expand All @@ -82,6 +107,9 @@ ${
},
));

if (fetchFailed) {
process.exit(1);
}
process.exit(0);
});
}
Expand Down