Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfepy fails to build from source in Debian Unstable #496

Closed
kkremitzki opened this Issue Jan 29, 2019 · 9 comments

Comments

Projects
None yet
2 participants
@kkremitzki
Copy link

kkremitzki commented Jan 29, 2019

This issue is covered in more detail here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917675

As a result of this bug, sfepy has been removed from Debian Testing, which would prevent it from being included in the upcoming Debian 10 release.

An abbreviated error message is:

sfepy/discrete/common/extmods/common.h:109:59: error: expected expression before ')' token

@rc rc added the defect label Jan 29, 2019

@rc

This comment has been minimized.

Copy link
Member

rc commented Jan 29, 2019

Thanks for the report!

It looks like the problem is caused by the SDIR preprocessor variable, that should define the directory where a source file resides. I wonder what it expands to in the failed build.

@rc

This comment has been minimized.

Copy link
Member

rc commented Jan 29, 2019

@BubuLK This might be a good issue for you :)

@kkremitzki

This comment has been minimized.

Copy link
Author

kkremitzki commented Jan 30, 2019

All I see in the build log is
error: Command "x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -D__SDIR__=\"sfepy/discrete/common/extmods\" -DSFEPY_PLATFORM=0 -Dinline=inline -Isfepy/discrete/common/extmods -I/usr/lib/python2.7/dist-packages/numpy/core/include -I/usr/include/python2.7 -c sfepy/discrete/common/extmods/mesh.c -o build/temp.linux-amd64-2.7/sfepy/discrete/common/extmods/mesh.o -MMD -MF build/temp.linux-amd64-2.7/sfepy/discrete/common/extmods/mesh.o.d -g -O2" failed with exit status 1

separated for visibility, -D__SDIR__=\"sfepy/discrete/common/extmods\".

@rc

This comment has been minimized.

Copy link
Member

rc commented Jan 30, 2019

That looks pretty normal. But on my machine all the options are printed within '', as in:

compiling C sources
C compiler: x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC

compile options: '-D__SDIR__=\"sfepy/discrete/common/extmods\" -DSFEPY_PLATFORM=0 -Dinline=inline -DDEBUG_FMF -DSFEPY_PLATFORM=0 -Dinline=inline -Isfepy/discrete/common/extmods -I/home/user/.local/lib/python2.7/site-packages/numpy/core/include -I/usr/include/python2.7 -c'

The escaped quotes \" are there for that reason. I wonder why they are present in your output. Or why the closing escape is interpreted as the part of the __SDIR__ macro, leading to the error.

@kkremitzki

This comment has been minimized.

Copy link
Author

kkremitzki commented Feb 3, 2019

Are you using gcc8 by any chance?

@rc

This comment has been minimized.

Copy link
Member

rc commented Feb 3, 2019

No, I have gcc 5.4.0 or 4.8.4.

@rc

This comment has been minimized.

Copy link
Member

rc commented Feb 11, 2019

I have just merged #502 which should fix this issue. Can you confirm?

@kkremitzki

This comment has been minimized.

Copy link
Author

kkremitzki commented Feb 13, 2019

Yep, that fixed it! Unfortunately the soft freeze just started yesterday so it's too late to make it into Debian 10, but I'll get the package fixed up ASAP.

@kkremitzki kkremitzki closed this Feb 13, 2019

@rc

This comment has been minimized.

Copy link
Member

rc commented Feb 13, 2019

OK, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.