Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed regression in MultiXml.parse #22

Merged
merged 1 commit into from Apr 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

koraktor commented Apr 16, 2012

This was caused by 6804ffc.

When calling MultiXml.parse without setting a parser before, this would cause errors like:

MultiXml::ParseError: undefined method `parse' for :ox:Symbol

PS: This seems to be a strange "bug" in Ruby that would cause .parse to return the return value of .default_parser instead of .parser=.

@sferik sferik added a commit that referenced this pull request Apr 16, 2012

@sferik sferik Merge pull request #22 from koraktor/fix-default-parser
Fixed regression in MultiXml.parse
69138d4

@sferik sferik merged commit 69138d4 into sferik:master Apr 16, 2012

Owner

sferik commented Apr 16, 2012

Thanks for the patch. I merged it and pushed a new gem but would you mind adding tests to ensure that this doesn't break again in the future?

Contributor

koraktor commented Apr 16, 2012

Sure.

@koraktor koraktor added a commit to koraktor/multi_xml that referenced this pull request Apr 16, 2012

@koraktor koraktor Added test case for #22 9ba8125

@sferik sferik added a commit that referenced this pull request Apr 16, 2012

@sferik sferik Merge pull request #23 from koraktor/parser-test
Added test case for #22
61629a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment