Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed regression in MultiXml.parse #22

Merged
merged 1 commit into from

2 participants

@koraktor

This was caused by 6804ffc.

When calling MultiXml.parse without setting a parser before, this would cause errors like:

MultiXml::ParseError: undefined method `parse' for :ox:Symbol

PS: This seems to be a strange "bug" in Ruby that would cause .parse to return the return value of .default_parser instead of .parser=.

@sferik sferik merged commit 69138d4 into sferik:master
@sferik
Owner

Thanks for the patch. I merged it and pushed a new gem but would you mind adding tests to ensure that this doesn't break again in the future?

@koraktor

Sure.

@koraktor koraktor referenced this pull request from a commit in koraktor/multi_xml
@koraktor koraktor Added test case for #22 9ba8125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 16, 2012
  1. @koraktor

    Fixed regression in MultiXml.parse

    koraktor authored
    This was caused by 6804ffc.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  lib/multi_xml.rb
View
1  lib/multi_xml.rb
@@ -59,6 +59,7 @@ class << self
def parser
return @@parser if defined?(@@parser)
self.parser = self.default_parser
+ @@parser
end
# The default parser based on what you currently
Something went wrong with that request. Please try again.