Change JRuby CI-matrix to jruby-19mode #1078

Closed
mshibuya opened this Issue Apr 12, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Collaborator

mshibuya commented Apr 12, 2012

With EOL of Ruby1.8.7 in sight, it appears to be natural that we start testing against jruby-19mode and stop for jruby-18mode.
(And that enables changing Paperclip dependency to 3.0, the latest)

Can I make this change to Travis matrix?
Is there anyone who still needs RailsAdmin to be tested against jruby-18mode?

@ghost ghost assigned mshibuya Apr 12, 2012

Collaborator

bbenezech commented Apr 12, 2012

I'm all for it.

Collaborator

mshibuya commented Apr 13, 2012

Also for Rubinius, forget rbx-18mode for now and include rbx-19mode into CI matrix.
Rubinus on 19mode, unlike 18mode, seems not to produce a bunch of mysterious spec failures.

@sferik
What's your opinion on this?

Owner

sferik commented Apr 13, 2012

I was tweaking the CI matrix earlier today. I think testing on jruby-19mode makes sense. I'll make the change now.

@sferik sferik closed this Apr 13, 2012

Owner

sferik commented Apr 13, 2012

I tried making this change but it broke the build: http://travis-ci.org/sferik/rails_admin/builds/1079487

Collaborator

mshibuya commented Apr 13, 2012

This is weird - running specs locally doesn't show such a big problem for both Rubinius and JRuby.

Anyway, I'll do the rest, try to see if I can work this out.
Thanks for reply.

@mshibuya mshibuya reopened this Apr 13, 2012

@mshibuya mshibuya closed this in 9ba234c May 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment