overriding to_xs in 1.8.7 with incorrect method signature. #1087

Closed
maxwell opened this Issue Apr 17, 2012 · 3 comments

Comments

Projects
None yet
3 participants

maxwell commented Apr 17, 2012

Since merging rails_admin into Diaspora, a couple of places where we indirectly used to_xs (in this case, generating atom feeds), we have seen some test failures on 1.8.7, complaining

  1) UsersController#public renders xml if atom is requested
     Failure/Error: get :public, :username => @user.username, :format => :atom
     ActionView::Template::Error:
       wrong number of arguments (1 for 0)
     # ./app/views/users/public.atom.builder:9:in `_app_views_users_public_atom_builder___721030142_2275752980'
     # ./spec/controllers/users_controller_spec.rb:45

(ill post the link to travis when it wants to behave and load)

When I completely remove rails_admin, the failures on 1.8.7 go away.

Any ideas what rails_admin dependency might be causing this?

More info:diaspora/diaspora#3154

other info:

Collaborator

mshibuya commented Apr 26, 2012

Have you checked this?
http://stackoverflow.com/a/8717053

RailsAdmin has dependency to hpricot through rack-pjax.

Collaborator

bbenezech commented Apr 26, 2012

Yeah, John on SO explains it very well.

Collaborator

mshibuya commented Jun 16, 2012

Closing because RA can do nothing about it.
FYI: eval/rack-pjax#15

@mshibuya mshibuya closed this Jun 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment