Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Multiple PJAX issues #1119

Closed
amacneil opened this Issue May 9, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

amacneil commented May 9, 2012

"Home" link in the header needs to not have the pjax class, because if we happen to have [data-pjax-container] on our homepage then it tries to load the homepage inside rails_admin (which obviously looks really weird).

Second issue - control/cmd-click is broken (which usually opens page in new tab). This works with the vanilla jquery.pjax.js, so I'm assuming that the little "Loading..." thing you have coming up in the bottom right is breaking the cmd-click.

I would be grateful if there was a way to disable pjax completely while these issues are worked out :)

Collaborator

bbenezech commented May 9, 2012

Hello Adrian,

Can you give me more infos about your environnement? I can't reproduce the cmd-click issue on MacOS(Firefox/Chrome)

@bbenezech bbenezech added a commit that referenced this issue May 9, 2012

@bbenezech bbenezech fallback on browser's native title for tooltips (fix #1081)
fix show in app opened in pjax (ref #1119, fix #1111)
a8af6e7
Contributor

amacneil commented May 10, 2012

Just saw there's a gem release now, awesome :)

I'm using OSX (Lion), latest stable Chrome 18, latest revision 3c7f7a4 of rails_admin. Also just tested in Firefox (12) and same problem.

To be clear, I'm talking about cmd+click to open the link in a new tab, not the control+click to open the context menu on OSX.

If I get some time later I'll do some digging and see if I can figure out the cause.

Collaborator

bbenezech commented May 16, 2012

Middle-click works fine (same functionality).
Pjax demo works the way you intend it too.

I need to have a look at my init hook.

@bbenezech bbenezech was assigned May 16, 2012

@amacneil amacneil added a commit to amacneil/rails_admin that referenced this issue May 17, 2012

@amacneil amacneil Fix middle/cmd click not opening in new tab. Ref #1119 743e775

@amacneil amacneil referenced this issue May 17, 2012

Merged

PJAX fixes #1137

@sferik sferik closed this in 7ea447a May 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment