Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Other custom text editors? (markdown via MarkItUp) #1235

Closed
Tuckie opened this Issue Jul 3, 2012 · 3 comments

Comments

Projects
None yet
3 participants

Tuckie commented Jul 3, 2012

After seeing the codemirror pull: #1164 I was wondering how difficult it would be to add other client side editors into rails admin?

I'm looking at incorporating markdown support into my application, but a little extra assistance via MarkItUp is probably going to be needed.

https://www.ruby-toolbox.com/gems/markitup_rails3
http://markitup.jaysalvat.com/home/

Looking at code changes that was required, it doesn't appear to be very modular. Is there a better way to cleanly integrate different editors (maybe just as a markdown field type)?

Collaborator

mshibuya commented Jul 9, 2012

I agree with the notion that it isn't modular. We should clean it up.

Separating each of richtext supports into different classes, like in meta code

class RailsAdmin::Config::Fields::Types::CKEditor < Text; end
class RailsAdmin::Config::Fields::Types::CodeMirror < Text; end
...

will improve modularity, although problem will be still left in JS logics in ra.widgets.coffee.

Is there anyone who is up to this task? :)

@mshibuya mshibuya was assigned Aug 8, 2012

👍

Collaborator

mshibuya commented Nov 10, 2014

Modularization is already accomplished by 967efc6.
Please submit PR is you're still interested in markdown support.

@mshibuya mshibuya closed this Nov 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment