Added pjax? option to Actions::Base #1295

Merged
merged 1 commit into from Feb 6, 2013

6 participants

@stympy

Some actions, like logging in as another user, should be rendered
in the app, not via pjax. This change allows an action to indicate
how it should be rendered.

@stympy stympy Added a configurable option for pjax
Some actions, like logging in as another user, should be rendered
in the app, not via pjax.  This change allows an action to indicate
how it should be rendered.
115f20c
@travisbot

This pull request passes (merged 115f20c into 3c83b27).

@mshibuya
Collaborator

This is cool, but we need tests for this before merging in.
Can you handle it?

@stympy

Well, if I could actually run the tests... :) After bundling and running rake, I get this error: git://github.com/meskyanichi/mongoid-paperclip.git (at develop) is not checked out. Please run bundle install

@mshibuya
Collaborator

You could try either:

$ bundle install
$ bundle exec rake

or

$ bundle install
$ bundle exec rspec
@mshibuya mshibuya was assigned Oct 29, 2012
@axsuul

Hoping this gets merged in soon!

@bbenezech bbenezech merged commit ed8d18c into sferik:master Feb 6, 2013

1 check passed

Details default The Travis build passed
@coveralls

Coverage Status

Changes Unknown when pulling 115f20c on stympy:master into ** on sferik:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment