Add checkbox to select/unselect all fields when exporting (Issue #1241) #1302

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

Add checkbox to select/unselect all fields when exporting (solve issue #1241).

I hope this is right.

I didn't make the test, if it's a need for this feature, please let me know and I'll make it.

This pull request passes (merged 832219a into e674017).

Collaborator

bbenezech commented Aug 31, 2012

Thanks!

You can't test this yet (no cucumber/webkit or similar stack yet :/ )

About the feature, it already exists, clicking the model/relation name will revert selection of all depending fields.
I think we mostly need a popover to tell users about that :D

Checkbox is ok too, but then you need to make the aforementioned behavior consistent (check all/uncheck all instead of inverse all). Check the coffee files and refactor what you want (onclick is a bit ugly)

I notice the model/relation name revert selection. But this is not to invert, and it's for all the checkboxes as the issue 1241 asked.

Is there a reason that this pull request could not be merged yet? A client requested the same feature, and I'll have to implement it anyway, if there are issues with this pull request.

Collaborator

bbenezech commented Jan 25, 2013

The feature already exist: when you click on a legend, all boxes get checked/unchecked.

I am not sure we actually need more than this.

What is missing is a tooltip to inform user about the feature.

What already exists is not the same feature.

This was referenced Mar 27, 2013

Collaborator

mshibuya commented Jul 1, 2013

This change is already included in #1580.

mshibuya closed this Jul 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment