Add json field datatype #1757

Merged
merged 7 commits into from Feb 7, 2014

Conversation

Projects
None yet
4 participants
@linchus
Contributor

linchus commented Sep 23, 2013

Fixes #1715

@linchus linchus closed this Sep 23, 2013

@linchus linchus reopened this Sep 23, 2013

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Sep 23, 2013

Coverage Status

Coverage increased (+0.05%) when pulling 9f80590 on linchus:master into 6aed4e4 on sferik:master.

Coverage Status

Coverage increased (+0.05%) when pulling 9f80590 on linchus:master into 6aed4e4 on sferik:master.

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Sep 23, 2013

Coverage Status

Coverage decreased (-0.08%) when pulling 9f80590 on linchus:master into 6aed4e4 on sferik:master.

Coverage Status

Coverage decreased (-0.08%) when pulling 9f80590 on linchus:master into 6aed4e4 on sferik:master.

@mshibuya

This comment has been minimized.

Show comment Hide comment
@mshibuya

mshibuya Sep 24, 2013

Collaborator

Why did you inherit from RailsAdmin::Config::Fields::Base?
Making Json as a subclass of RailsAdmin::Config::Fields::Types::Text will be a bit cleaner, as Serialized does.

Also, we need some specs to get this merged in. Could you please write them?

Collaborator

mshibuya commented Sep 24, 2013

Why did you inherit from RailsAdmin::Config::Fields::Base?
Making Json as a subclass of RailsAdmin::Config::Fields::Types::Text will be a bit cleaner, as Serialized does.

Also, we need some specs to get this merged in. Could you please write them?

@linchus

This comment has been minimized.

Show comment Hide comment
@linchus

linchus Sep 24, 2013

Contributor

Sure

Contributor

linchus commented Sep 24, 2013

Sure

@linchus

This comment has been minimized.

Show comment Hide comment
@linchus

linchus Sep 24, 2013

Contributor

I've confused a bit (
Your specs work with SQLite database, but json type is supported only in Postgresql (

Contributor

linchus commented Sep 24, 2013

I've confused a bit (
Your specs work with SQLite database, but json type is supported only in Postgresql (

@mshibuya

This comment has been minimized.

Show comment Hide comment
@mshibuya

mshibuya Oct 24, 2013

Collaborator

We have postqres Travis build and of course can be run locally.
Please refer how we do here.

Collaborator

mshibuya commented Oct 24, 2013

We have postqres Travis build and of course can be run locally.
Please refer how we do here.

@benjiwheeler

This comment has been minimized.

Show comment Hide comment
@benjiwheeler

benjiwheeler Jan 30, 2014

hey, what's the status of this? is there any way i can help?

hey, what's the status of this? is there any way i can help?

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Feb 1, 2014

Coverage Status

Coverage decreased (-1.57%) when pulling c920dc8 on linchus:master into 2010c96 on sferik:master.

Coverage Status

Coverage decreased (-1.57%) when pulling c920dc8 on linchus:master into 2010c96 on sferik:master.

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Feb 3, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling 622f1cc on linchus:master into 4d5fa97 on sferik:master.

Coverage Status

Coverage decreased (-0.01%) when pulling 622f1cc on linchus:master into 4d5fa97 on sferik:master.

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Feb 3, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling e2cdfd3 on linchus:master into 4d5fa97 on sferik:master.

Coverage Status

Coverage decreased (-0.01%) when pulling e2cdfd3 on linchus:master into 4d5fa97 on sferik:master.

mshibuya added a commit that referenced this pull request Feb 7, 2014

@mshibuya mshibuya merged commit acd360c into sferik:master Feb 7, 2014

1 check failed

default The Travis CI build failed
Details
@mshibuya

This comment has been minimized.

Show comment Hide comment
@mshibuya

mshibuya Feb 7, 2014

Collaborator

Thanks! 👍

Collaborator

mshibuya commented Feb 7, 2014

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment