Rails 4.2 has deprecated serialized_attributes
#2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,13 @@ def pretty_name | |||
| end | |||
|
|
|||
| def type | |||
| if model.serialized_attributes[property.name.to_s] | |||
| serialized = if Rails.version < '4.2' | |||
There was a problem hiding this comment.
Could this be pulled into a private method #serialized?
There was a problem hiding this comment.
good call, giving it a shot
There was a problem hiding this comment.
works fine, thanks @nickrivadeneira!
|
Re: coveralls Does coveralls only run against a single version of Rails? I wonder if |
iwz
force-pushed
the
serialized_attributes-rails-4.2
branch
from
0c9eed4
to
6a62a2c
Compare
* Use the new `type_for_attribute` method instead
iwz
force-pushed
the
serialized_attributes-rails-4.2
branch
from
6a62a2c
to
698f06a
Compare
|
Don’t worry too much about Coveralls. Thanks for making this change. |
sferik
added a commit
that referenced
this pull request
Dec 24, 2014
Rails 4.2 has deprecated `serialized_attributes`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type_for_attributemethod instead