Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Model display name fixes #319
When the model name has been modified with:
that name isn't used when it should be used for the dashboard table, the breadcrumbs, page name, history entries and delete messages.
This fixes issue: https://github.com/sferik/rails_admin/issues/#issue/318
Hi Wolfram and thank you for the fix!
Your approach is on the right track, but I think it should be taken bit further. The old code allowed to define label per section (navigation, update, create, list), but that was indeed an overkill and wasn't even implemented in the dashboard. I think simplifying the label definition to a single point of entry is definitely a good idea, but it should not be contained in the navigation section, but on a higher level.
Therefore I'd propose we'd move
In configuration one would use:
And in code:
Do you find this proposal acceptable and change the pull request accordingly?
PS. I'm also thinking we should do same kind of move with
Thanks for your reply. To be honest, I hadn't dove deep enough into the architecture to fully understand the bigger picture. Conceptually what you're proposing makes sense, but I'll have to get my head wrapped around the configuration layer in more detail than I had previously. I'll give it a try.