Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added PSD and updated the README #40

Merged
merged 3 commits into from May 10, 2012

Conversation

Projects
None yet
3 participants
Contributor

nvk commented May 10, 2012

My markdown is weak, feel free to change it around.

This pull request passes (merged 428d472 into bbd8998).

@sferik sferik and 1 other commented on an outdated diff May 10, 2012

@@ -1,4 +1,7 @@
-# Twitter CLI [![Build Status](https://secure.travis-ci.org/sferik/t.png?branch=master)][travis] [![Dependency Status](https://gemnasium.com/sferik/t.png?travis)][gemnasium] [![Click here to make a donation to T](http://www.pledgie.com/campaigns/17330.png)][pledgie]
+# Twitter CLI [![Build Status](https://secure.travis-ci.org/sferik/t.png?branch=master)][travis] [![Dependency Status](https://gemnasium.com/sferik/t.png?travis)][gemnasium] [![Click here to make a donation to T](http://www.pledgie.com/campaigns/17330.png)][pledgie]
+
+# [![Application icon](https://github.com/nvk/t/raw/7f9b6f02f66e736b3e081b4efe8e4578037d630e/cli-bird.png)][icon]
@sferik

sferik May 10, 2012

Owner

This image should use the canonical URL: https://github.com/sferik/t/raw/master/cli-bird.png

@nvk

nvk May 10, 2012

Contributor

will make the change and do another pull request.

@sferik

sferik May 10, 2012

Owner

No need to make a new pull request. If you just push your changes the pull request should update automatically.

@sferik

sferik May 10, 2012

Owner

Is there anything wrong with the URL I provided?

@nvk

nvk May 10, 2012

Contributor

Yours works, just found odd that the same doesn't work with my url.

@sferik sferik commented on the diff May 10, 2012

README.md
@@ -1,4 +1,7 @@
-# Twitter CLI [![Build Status](https://secure.travis-ci.org/sferik/t.png?branch=master)][travis] [![Dependency Status](https://gemnasium.com/sferik/t.png?travis)][gemnasium] [![Click here to make a donation to T](http://www.pledgie.com/campaigns/17330.png)][pledgie]
+# Twitter CLI [![Build Status](https://secure.travis-ci.org/sferik/t.png?branch=master)][travis] [![Dependency Status](https://gemnasium.com/sferik/t.png?travis)][gemnasium] [![Click here to make a donation to T](http://www.pledgie.com/campaigns/17330.png)][pledgie]
@sferik

sferik May 10, 2012

Owner

Why/how was this line modified?

@nvk

nvk May 10, 2012

Contributor

i maybe have touched, no thing changed.

@sferik

sferik May 10, 2012

Owner

It's probably extra whitespace. Can you check for that?

@nvk

nvk May 10, 2012

Contributor

yes, space at the end to make a new line.

@sferik sferik and 1 other commented on an outdated diff May 10, 2012

@@ -285,6 +288,7 @@ fashion. If critical issues for a particular implementation exist at the time
of a major release, support for that Ruby version may be dropped.
## Copyright
-Copyright (c) 2011 Erik Michaels-Ober. See [LICENSE][] for details.
-
+Copyright (c) 2011 Erik Michaels-Ober. See [LICENSE][] for details.
+App ICON by [@nvk][icon].
@sferik

sferik May 10, 2012

Owner

Any particular reason why the word "icon" is capitalized here? Also the alternate text for the image says "Application icon" while this text says "App icon". The two should be consistent, one way or the other.

@nvk

nvk May 10, 2012

Contributor

Ok.

This pull request passes (merged 3193ee3 into bbd8998).

sferik added a commit that referenced this pull request May 10, 2012

Merge pull request #40 from nvk/master
Added PSD and updated the README

@sferik sferik merged commit 9d8a31f into sferik:master May 10, 2012

sferik added a commit that referenced this pull request May 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment