Implemented GET followers/list and GET friends/list for API 1.1 changes #331

Merged
merged 3 commits into from Nov 30, 2012

Conversation

Projects
None yet
3 participants
@tibbon

tibbon commented Nov 30, 2012

I followed the contributors guidelines for tests, code and documentation.

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Nov 30, 2012

Owner

This looks good. The only thing I see that's missing is documentation of all the optional parameters that can be passed in to GET followers/list and GET friends/list, specifically, skip_status and include_user_entities.

If you add that documentation and push another commit to your branch, GitHub will automatically add it to this pull request.

Owner

sferik commented Nov 30, 2012

This looks good. The only thing I see that's missing is documentation of all the optional parameters that can be passed in to GET followers/list and GET friends/list, specifically, skip_status and include_user_entities.

If you add that documentation and push another commit to your branch, GitHub will automatically add it to this pull request.

@tibbon

This comment has been minimized.

Show comment Hide comment
@tibbon

tibbon Nov 30, 2012

Will add those in this afternoon and commit. Thanks for the feedback! This makes me want to do all my code like this.

tibbon commented Nov 30, 2012

Will add those in this afternoon and commit. Thanks for the feedback! This makes me want to do all my code like this.

@stve

This comment has been minimized.

Show comment Hide comment
@stve

stve Nov 30, 2012

Collaborator

nice work @tibbon 😻

Collaborator

stve commented Nov 30, 2012

nice work @tibbon 😻

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Nov 30, 2012

Owner

I'd like to push a new release tonight, so I'll just merge this in as-is and add the documentation myself.

@tibbon Thanks again for your work on this! I'm happy to add you as a collaborator on this repository if you'd like to continue to make contributions. If not, that's okay too.

Owner

sferik commented Nov 30, 2012

I'd like to push a new release tonight, so I'll just merge this in as-is and add the documentation myself.

@tibbon Thanks again for your work on this! I'm happy to add you as a collaborator on this repository if you'd like to continue to make contributions. If not, that's okay too.

sferik added a commit that referenced this pull request Nov 30, 2012

Merge pull request #331 from tibbon/friend_and_follower_lists
Implemented GET followers/list and GET friends/list for API 1.1 changes

@sferik sferik merged commit 9c920b6 into sferik:master Nov 30, 2012

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Dec 1, 2012

Owner

FYI, this was all I did to clean up this pull request: e54a796.

Owner

sferik commented Dec 1, 2012

FYI, this was all I did to clean up this pull request: e54a796.

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Dec 1, 2012

Owner
Owner

sferik commented Dec 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment