Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Correct retweet response. Retweeted status should be the original tweet #541
I am suggesting to revert the fix for issuse #228. As opposed to Issue #228, the Twitter api response with original tweet as the retweeted_status is actually a correct behaviour. Similarly, all statuses list endpoints would consistently return the original tweet as the retweeted_status, whenever a retweet is encountered.
However, the fix for issue #228 somehow reversed the response from Twitter API for POST retweet, making the gem behaviour inconsistent when encountering a retweet.
Also, the name, "retweeted_status", implies the "status being retweeted", thus the fix on issue #228 is wrong as the developer who fixed #228 mistaken "retweeted_status" as "the status generated due to taking a retweet action". This might also suggests Twitter::Tweet with alias_method for retweet as retweeted_status is also wrong.
The twitter documentation, https://dev.twitter.com/docs/api/1.1/post/statuses/retweet/:id, has example demonstrating that original tweet is the retweeted_status. (Although the summary of the api is confusing, which I will file a bug to api.)
Also, on a side note, Issue #228 thought that Twitter API has a bug and implemented a fix at the Gem level. I think this is a bad practice. If we think the API is faulty, we should file a bug to Twitter instead.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
also documentation, https://dev.twitter.com/docs/platform-objects/tweets, describe retweeted_status as
"Users can amplify the broadcast of tweets authored by other users by retweeting. Retweets can be distinguished from typical Tweets by the existence of a retweeted_status attribute. This attribute contains a representation of the original Tweet that was retweeted. Note that retweets of retweets do not show representations of the intermediary retweet, but only the original tweet. (Users can also unretweet a retweet they created by deleting their retweet.)"