Resolves #75 #78

Merged
1 commit merged into from Oct 9, 2010

Conversation

Projects
None yet
2 participants
@laserlemon
Collaborator

laserlemon commented Oct 9, 2010

This resolves the issue with generating an invalid OAuth signature for non-GET requests. However, ROAuth is botching the signature independently of #75 when sending parameters that require URL encoding. I'll be submitting a fix to them next.

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Oct 9, 2010

Owner

Thanks for this fix! I wonder how we can test to make sure requests are signed correctly?

Owner

sferik commented Oct 9, 2010

Thanks for this fix! I wonder how we can test to make sure requests are signed correctly?

@laserlemon

This comment has been minimized.

Show comment Hide comment
@laserlemon

laserlemon Oct 9, 2010

Collaborator

The ROAuth gem is able to verify incoming OAuth requests as well. That's what I'd recommend.

Collaborator

laserlemon commented Oct 9, 2010

The ROAuth gem is able to verify incoming OAuth requests as well. That's what I'd recommend.

@sferik

This comment has been minimized.

Show comment Hide comment
@sferik

sferik Oct 10, 2010

Owner

Are such tests something you'd be interested in working on? You seem like the expert on roauth. :)

Owner

sferik commented Oct 10, 2010

Are such tests something you'd be interested in working on? You seem like the expert on roauth. :)

@laserlemon

This comment has been minimized.

Show comment Hide comment
@laserlemon

laserlemon Oct 10, 2010

Collaborator

Ha, sure. I'll take a stab at it.

Collaborator

laserlemon commented Oct 10, 2010

Ha, sure. I'll take a stab at it.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment