New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit version 1.0 to CRAN #140

Closed
sfirke opened this Issue Oct 13, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@sfirke
Owner

sfirke commented Oct 13, 2017

Should this be version 1.0? It has breaking changes, and I think represents an API paradigm shift with tabyl. Plus honestly, I'm out of big ideas for this package after this, and don't see anything that could merit a 1.0.

To dos before that:

DONE

  • Build out tabyl vignette (#132)
  • Publicize new tabyl + adorn functionality, solicit demo users to try out the dev version
  • Address any other issues like #100 , #77, #153, #168 that might be germane to this revision.
  • Review #146 #178
  • See if clean_names tests pass for other Windows users - having some weird issues locally
  • After next version of snakecase goes to CRAN, remove Remotes: from DESCRIPTION and add snakecase (>= 0.9) (confirm V number) to Imports
  • Create packagedown website
  • Process remaining issues, closing and tagging appropriately.
  • Run lintr #172
  • Update NEWS.Md to describe release
  • Bump version to 1.0 in Description and NEWS
  • Remove note about "tabyl is not currently not on CRAN" from tabyls vignette & README
  • Check that image paths are right per CRAN standards for Index.Rmd - it won't knit

PENDING

  • Submit!

AFTER SUBMITTING

  • Write a blog post publicizing it
  • Tweet, incl. link to pkgdown site
  • GitHub release
  • Blogpost?
  • Optional tweaks to packagedown site #156
  • Add stable badge to repo

90% of this release is done, now it's the dull stuff. Must. Wrap. This. Up.

@sfirke sfirke self-assigned this Nov 21, 2017

@sfirke

This comment has been minimized.

Owner

sfirke commented Jan 19, 2018

Getting closer...

@sfirke sfirke changed the title from Submit to CRAN to Submit version 1.0 to CRAN Feb 26, 2018

@garthtarr

This comment has been minimized.

Contributor

garthtarr commented Mar 7, 2018

I think this is a very worthy 1.0 release! I was just showing off some of the new functionality today to someone and couldn't work out why it wasn't working (they had the CRAN release installed). My suggestion from your pending list, FWIW, is to

  • Update NEWS.Md to describe release
  • Bump version to 1.0 in Description and NEWS
  • Submit!

Full disclosure: I want to use it in my teaching for R novices without having to introduce devtools::install_github(...) ;)

@sfirke

This comment has been minimized.

Owner

sfirke commented Mar 7, 2018

I really appreciate that, Garth. I've been haunted by this idea that if I'm calling it 1.0, I should get everything just right. But I think the functionality is finished, and at this point I'm hurting the user experience by requiring installation from GitHub. Too much tinkering around the edges.

I hereby vow to submit to CRAN by end of March at the latest! 🥅

@garthtarr

This comment has been minimized.

Contributor

garthtarr commented Mar 7, 2018

Great news!

@sfirke

This comment has been minimized.

Owner

sfirke commented Mar 17, 2018

I think I'm done with version 1.0. This update breaks a few CRAN packages that depend on janitor; I may give those maintainers some time to adjust, but otherwise I'm ready to submit what I have on GitHub now.

And then maybe leave this package alone for a little while 😜

@sfirke

This comment has been minimized.

Owner

sfirke commented Mar 22, 2018

I submitted this AM 🤞 My previous releases have gotten quick responses, but this is a more complicated cases (it causes WARNINGs for downstream dependencies). Those cases are addressed in my cran-comments but I expect at the very least will take more inspection on the part of CRAN folks.

@sfirke sfirke closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment