Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli-blanket does not work with ember-cli-qunit 2.2.2 or newer. #162

Open
nathanhammond opened this issue Sep 14, 2016 · 11 comments

Comments

@nathanhammond
Copy link

@nathanhammond nathanhammond commented Sep 14, 2016

The fix here is for ember-cli-blanket to hook ember-cli-test-loader to insert its module instrumentation. That's the ideal insertion point for what you're trying to accomplish. This also has the benefit of reducing the number of intimate and private APIs inside of Ember's module loading infrastructure that it needs to touch. Also it no longer has to support autostart as a feature since modules will be instrumented as part of the same loading step that Ember normally uses.

Reference: ember-cli/ember-cli-qunit#147

@rwwagner90

This comment has been minimized.

Copy link
Contributor

@rwwagner90 rwwagner90 commented Sep 14, 2016

👍 definitely broken for all my addons that I have updated 😞

@sglanzer

This comment has been minimized.

Copy link
Owner

@sglanzer sglanzer commented Sep 16, 2016

I'd love to find time to fix this, but most of my effort on code coverage has been dedicated to ember-cli-code-coverage these days. I'm more than happy to accept a PR, but I doubt I'll have time to fix this for at least a week or two.

@luketheobscure

This comment has been minimized.

Copy link

@luketheobscure luketheobscure commented Oct 6, 2016

@sglanzer should we start migrating our projects over to ember-cli-code-coverage then?

@sglanzer

This comment has been minimized.

Copy link
Owner

@sglanzer sglanzer commented Oct 6, 2016

@luketheobscure Yeah, with the 0.3 release ember-cli-code-coverage supports addons, so I would encourage a swap. I haven't marked this repo as deprecated yet, but that's probably the next step. I don't think @jschilli or I have any time to actively work on maintaining this and I believe ember-cli-code-coverage is the way forward

@sglanzer

This comment has been minimized.

Copy link
Owner

@sglanzer sglanzer commented Oct 6, 2016

@jschilli @rwjblue @kategengler any thoughts on endorsing a cutover?

@luketheobscure

This comment has been minimized.

Copy link

@luketheobscure luketheobscure commented Oct 27, 2016

@sglanzer It would still be helpful to get this fixed. I can't switch over to ember-cli-code-coverage until they get it playing nicely with CoffeeScript (kategengler/ember-cli-code-coverage#55).

@rwwagner90

This comment has been minimized.

Copy link
Contributor

@rwwagner90 rwwagner90 commented Oct 27, 2016

@luketheobscure I think we ought to have everyone focus on ember-cli-code-coverage, rather than putting time into trying to get this working again.

@sglanzer

This comment has been minimized.

Copy link
Owner

@sglanzer sglanzer commented Oct 27, 2016

@luketheobscure I have to agree with @rwwagner90 - unfortunately the time available to dedicate to this type of project is severely limited, so we need to throw any effort behind a blessed implementation

I'm also more than happy to accept a PR and publish a new release if you find that to be a shorter path for resolving your situation

@rwwagner90

This comment has been minimized.

Copy link
Contributor

@rwwagner90 rwwagner90 commented Aug 31, 2017

Should we close this issue, since ember-cli-code-coverage is the new thing to use?

@sglanzer

This comment has been minimized.

Copy link
Owner

@sglanzer sglanzer commented Aug 31, 2017

@rwwagner90

This comment has been minimized.

Copy link
Contributor

@rwwagner90 rwwagner90 commented Sep 5, 2017

@sglanzer deprecating does sound like a good idea. I was just looking through open issues that are lingering in my GitHub and wanted to see what you thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.