fix IJuliaExt #117
Merged
fix IJuliaExt #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IJuliaExt in its current form fails as the JSON dependency is directly called without being loaded in the extension module. This PR mainly prepends the PlotlyBase module to the
JSON.lowercall.Additionally, I found that at least in Google Colab (didn't try on local IJulia) the
include_plotlyjs=requirefails on the javascript side with an error hinting atmissing require. I did remove the kwarg as thecdnfallback works fine, but if for some reason the require was needed for some specific purpose I can try to have a look at how and if it can be put back.Link to the Google colab notebook used to test:
https://colab.research.google.com/drive/1Ehx_z35JqmwjvqN3ZxupyxynziqHzE2y?usp=sharing